Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a one second ladder climbing animation #14349

Merged
merged 3 commits into from Jun 6, 2023

Conversation

Skeletonman0
Copy link
Contributor

@Skeletonman0 Skeletonman0 commented Jun 2, 2023

[OBJECTS] [FEATURE]

About the PR

adds a 1 second climbing animation to ladders using code i stole borrowed from kitchen grinders

the person will face north, then visibly descend or ascend depending on if the ladder is the top or bottom
(this does not apply to the wall embed ladders)
https://gyazo.com/d0d4ecfcfdc5a93d69bccf30bc635287

at some point the ladders probably should stop using the icon state to determine if its a top or bottom ladder

Why's this needed?

neat thing i made while messing around. also currently you cant tell if someone is climbing a ladder

Changelog

(u)Skeletonman0
(+)Ladders now have a brief climbing animation

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features labels Jun 2, 2023
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Jun 2, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2023
@pali6 pali6 merged commit ae7292c into goonstation:master Jun 6, 2023
20 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants