Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene Booth Speedup Research #14415

Merged
merged 5 commits into from Jun 7, 2023

Conversation

Nexusuxen
Copy link
Contributor

@Nexusuxen Nexusuxen commented Jun 6, 2023

[MEDICAL] [QOL]

About the PR

Adds 3 new researches to the GeneTek console, which each add +25% to the Gene Booth's working speed. Each one subsequently reduces the waiting time by approximately 5 seconds (usually a bit lower due to it relying on Process()), down to ~5 seconds. This is done by giving the gene booth a new static var, process_speedup, and using that in the Process() check.

Below is a screenshot of the new researches.

image

Why's this needed?

The gene booth takes too damn long to work - 20 seconds per gene! And with dozens of people in a server and potentially half a dozen or more genes in the booth, that'll take a WHILE. This makes it at least bearable.

Changelog

(u)Nexusuxen
(*)Gene Booths can now be upgraded with GeneTek research to work faster by up to 75% (~5 seconds per gene).

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2023
@keywordlabeler keywordlabeler bot added A-Medical Deals with our medical system in some way C-QoL A quality of life improvement that makes the game easier to play labels Jun 6, 2023
@Nexusuxen
Copy link
Contributor Author

Ideally with this speedup the booth shaking/clonging should happen more frequently too, but it seems like Process() goes so slowly that it often finishes before it even gets a chance to clonk. Could do something with SPAWN() but honestly I don't feel like reworking gene booths to solve a non-existent problem.

Copy link
Member

@frawhst frawhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code/feature is good, small nitpick.

code/modules/medical/genetics/geneticsResearch.dm Outdated Show resolved Hide resolved
code/modules/medical/genetics/geneticsResearch.dm Outdated Show resolved Hide resolved
code/modules/medical/genetics/geneticsResearch.dm Outdated Show resolved Hide resolved
Nexusuxen and others added 3 commits June 6, 2023 20:33
Co-authored-by: aloe <frawhstdev@gmail.com>
Co-authored-by: aloe <frawhstdev@gmail.com>
Co-authored-by: aloe <frawhstdev@gmail.com>
@frawhst frawhst merged commit ee3d742 into goonstation:master Jun 7, 2023
20 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 7, 2023
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Jun 7, 2023
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Medical Deals with our medical system in some way C-QoL A quality of life improvement that makes the game easier to play size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants