Walls now save their girder material when built #14501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
keywordlabeler
bot
added
A-Materials
TobleroneSwordfish
requested changes
Jun 10, 2023
pali6
reviewed
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bug][Materials]
About the PR
Previously walls would just take on the material of whatever girder they were built on. This ended up in the girder basically eating whatever sheet was put onto it regardless of the material. Now the girder's material is stored in the wall until the wall is broken in which case a girder of the correct material spawns. Also, in order to place a sheet on a girder, the sheet has to be a metal sheet, so glass walls won't be able to be built.
Should fix:
#14385
#13870
Why's this needed?
Girders shouldn't determine a wall's material since the plating is what is actually visible from the outside.
Changelog