Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible reactor neutrons for infrared vision #14511

Merged
merged 1 commit into from Jun 10, 2023

Conversation

Garash2k
Copy link
Contributor

@Garash2k Garash2k commented Jun 10, 2023

[Objects][Feature]

About the PR

Makes it so that the neutrons emitted by the nuclear reactor are visible if the player has infrared vision, which is granted by mesons.

dreamseeker_deSiw9IwzI.mp4

I picked an icon named trace and used a green tint, if anyone has better sprite ideas I'm all eyes!

Why's this needed?

Looks nice, is fun, lets engineers see how harmful the reactor actually is, and how neutrons get stopped by objects/walls.
Amy gave the idea a thumbs up

Changelog

(u)Garash
(+)Neutrons emitted by the nuclear reactor are now visible for people with infrared vision, (which is granted by mesons amongst other means.)

@Garash2k Garash2k requested a review from Tarmunora as a code owner June 10, 2023 15:19
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2023
@keywordlabeler keywordlabeler bot added C-Feature A new feature or enhancements to existing features A-Game-Objects The point of this PR is to deal with a specific game object labels Jun 10, 2023
Copy link
Contributor

@amylizzle amylizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Elegant solution.

@ZeWaka ZeWaka merged commit 1b8a071 into goonstation:master Jun 10, 2023
26 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants