Make gas sharing transfer enough gas in order to attempt to equalize in one step #14539
Conversation
github-actions
bot
added
the
size/XS
pali6
added
the
C-Experimental
|
@Azrun @Laboredih123 give opinions, alternatives and/or thoughts if you want |
pali6
changed the title
|
I'll see how it feels during testing. |
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
pali6
added
E-DNM
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
|
oh yeah, it felt okay enough |
github-actions
bot
removed
the
S-Stale
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
|
oh |
About the PR
Before this PR gas amount transferred was the difference between the two gas mixtures divided by 5.
This PR makes it so enough gas is transferred that (ignoring other effects and gas transfers happening on the same tick) the two gas mixtures become equalized immediately. In practice this means that repressurization is faster but might also have various other side effects.
Making this PR largely to testmerge it and for people to post feedback on the change here.
(With the addition of this PR we might need to re-enable gas archiving because the directional artifacts can get a bit silly now. Shouldn't be a large performance impact.)
Why's this needed?
Repressurization being slow kinda sucks and the /5 constant looks pretty pulled out of someone's ass so changing it doesn't seem horrible. This should give feel of faster atmos.
Changelog