Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the crate manufacter to most maps #1458

Merged
merged 4 commits into from Jul 22, 2020

Conversation

Carbadox
Copy link
Contributor

@Carbadox Carbadox commented Jul 12, 2020

[FEATURE]

About the PR

Adds the crate manufactor to Atlas, Clarion, Destiny, Cog1, Cog2, Horizon and Oshan

Why's this needed?

It's a good feature and belongs in other maps as well

Changelog

(u)Carbadox
(*)Added the crate manufactor to Atlas, Clarion, Destiny, Cog1, Cog2, Horizon and Oshan

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Jul 12, 2020
@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Jul 12, 2020
@MarkNais
Copy link
Contributor

Changelog busted.
Love this change.

@Carbadox
Copy link
Contributor Author

Note : I didn't add one to Donut3 and Kondaru since their respective creators should probably make that decision

@UrsulaMejor
Copy link
Contributor

Not a fan of the placement on Horizon; specifically, it being right in front of the APC terminal that peeps might not know at a glance that they can mess with it at that distance. Might be good to revert and inform Warc so they can mess with it themselves

@MarkNais
Copy link
Contributor

Many wall mounted items are placed behind tables etc. I don't think that should be a "stopping" factor of the merge; but having Warc review/place it would be kind to her.

@Carbadox
Copy link
Contributor Author

Is that in regards to all maps or just Horizon, Mark?

@MarkNais
Copy link
Contributor

MarkNais commented Jul 13, 2020

Many wall mounted items are placed behind tables etc. I don't think that should be a "stopping" factor

All maps.

but having Warc review/place it would be kind to her.

Horizon specific.

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jul 17, 2020
@Carbadox
Copy link
Contributor Author

that should fix the merge conflict

@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jul 20, 2020
@UrsulaMejor UrsulaMejor merged commit a266a4c into goonstation:master Jul 22, 2020
github-actions bot pushed a commit that referenced this pull request Jul 22, 2020
@Carbadox Carbadox deleted the crate-fab branch December 10, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change C-Feature A new feature or enhancements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants