New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive inhand sprite changes #14605
Massive inhand sprite changes #14605
Conversation
…nto Massive-Inhands-polish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing:
/obj/item/reagent_containers/food/snacks/donut
which is made by the oven does not use the donut inhand.
No wrench subtypes (yellow, green etc) have inhands.
/obj/item/furniture_parts/rack
/obj/item/tank/emergency_oxygen
Missing right hand west facing inhands
Knife (also no left hand east)
Meatball (also no left hand east)
Burger (also no left hand east)
Donut (also no left hand east)
Bike horn
Vuvuzela (also no left hand east)
Syringe
Table parts
Metal sheet (also no left hand east)
Glass sheet (also no left hand east)
All books use the paper sprite, while there is significant cosmetic difference between a lot of books I would have expected these to use something more like the bible.
Golden (spare) ID card is quite hard to see in hand.
Burger is rather difficult to identify.
Saxophone does not look very different to previous?
…nto Massive-Inhands-polish
Fixed the various items not displaying their inhands, also fixed a few more like the hand labeler. Added missing inhand directions, the originals never had inhands for those directions but they have them now. I don't know why the syringe was on the list, I checked the branch and it has right hand facing west inhands, it's just that only the black needle is visible. All books should now use a separate generic looking 'book' inhand instead of paper, and paper continues to use the 'paper' inhand. Golden ID was a bit tricky, I made it a bit brighter, hopefully it's a bit easier to see now? The original items colors weren't cutting it for the inhands visibility Burger has a completely new inhand, now you hold the entire burger instead of just the bun being visible (tasty). Saxophone inhand change has been reverted, I can't remember what I was going for since it was a change early in the project, but I agree that it is quite minor, so now it will remain the same inhand that is currently in the game. In addition, I made some tiny tweaks to a couple inhands (Frosted donut outline, 1 pixel on wrench) and created brand new inhands for the cinnamon, robust, and robusted donut sprites (yummy). All donuts should use their proper inhands. |
…nto Massive-Inhands-polish
There might be requests for tweaks but this seems like an overall improvement and has been open a month. |
About the PR
Over 70 items have had their existing inhand sprites improved upon. These vary from simple recolors, to design changes and major improvements in the case that its item has been completely redesigned.
The positions of a few of these inhands have also been changed when it made them look nicer, such as improving the north facing sprites for some of them, instead of having the character awkwardly hold the item behind their back.
Various matsci inhands like metal/glass sheets, tiles, rods and cable coils also now use grayscale inhand sprite colors, which makes them look nicer when the material color of their icon sprites are overlayed.
A list of most of the inhand sprite changes is below, though the actual amount changed is likely higher.
Why's this needed?
Inhand sprites have received very little polish over the years in response to resprites, yet they are still something you see every time you hold an item, and deserve some care and polish.
There are many more inhands that are still old and in need of improvement, but this PR should help to modernize a lot of them to make more inhands match the look of the new sprites they are based on.
Changelog