Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds wall trophy for fish as a purchase for fishing tickets. #14642

Merged
merged 23 commits into from Jul 22, 2023

Conversation

TheColorCyan
Copy link
Contributor

@TheColorCyan TheColorCyan commented Jun 19, 2023

[GAME OBJECTS] [CATERING]

About the PR

Adds wall trophy for fish as a purchase for fishing tickets. You can attach it to a wall so everyone can see what kind of fish you caught.
I think its mostly done with the code part so draft status can be removed
nofish
trophy_screen
It has 2 vars that anchor stuff when set to true/false in mapping so it can be used and not stolen off the walls

Why's this needed?

Would be a nice addition to fishing so you could actually show off your fishing skills (and not just put all the fish on the floor). Make a fish museum today!!

Changelog

(u)Sian
(*)Added Wall Trophy for fish available as a ticket purchase in Fishing Supplies Vendor.

@keywordlabeler keywordlabeler bot added A-Catering Deals with food, the chef, the bar or otherwise edible/drinkable stuff A-Game-Objects The point of this PR is to deal with a specific game object labels Jun 19, 2023
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Jun 19, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2023
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2023
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2023
@Gannets
Copy link
Contributor

Gannets commented Jun 19, 2023

I like this idea.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2023
@TheColorCyan TheColorCyan marked this pull request as ready for review June 20, 2023 16:19
@TheColorCyan
Copy link
Contributor Author

this code scares me, i need someone to point where it is wrong

Copy link
Member

@frawhst frawhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enjoy this

code/obj/item/wall_trophy.dm Outdated Show resolved Hide resolved
code/obj/item/wall_trophy.dm Outdated Show resolved Hide resolved
code/turf/turf_autoalign.dm Outdated Show resolved Hide resolved
code/obj/item/wall_trophy.dm Outdated Show resolved Hide resolved
code/obj/item/wall_trophy.dm Outdated Show resolved Hide resolved
code/obj/item/wall_trophy.dm Outdated Show resolved Hide resolved
@frawhst frawhst self-assigned this Jul 4, 2023
@TheColorCyan TheColorCyan requested a review from frawhst July 4, 2023 16:07
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jul 19, 2023
@frawhst frawhst merged commit 49fc5da into goonstation:master Jul 22, 2023
21 checks passed
@TheColorCyan TheColorCyan deleted the fishtrophy branch July 22, 2023 01:24
github-actions bot pushed a commit that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Catering Deals with food, the chef, the bar or otherwise edible/drinkable stuff A-Game-Objects The point of this PR is to deal with a specific game object C-Sprites Automatically applied on any .dmi or icons folder change S-Stale An inactive PR that has had no updates in the past two weeks size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants