Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oshan medical tweaks #14684

Merged
merged 4 commits into from Jun 29, 2023
Merged

oshan medical tweaks #14684

merged 4 commits into from Jun 29, 2023

Conversation

TheTyrant25
Copy link
Contributor

[MAPPING] [QOL] [INPUT]

About the PR

  • Adds a bin (or disposal chute, if you'd rather call it that) to genetics.
  • Adds a door connecting robotics (the storage room, specifically) and the morgue, for easier access.

Why's this needed?

Geneticists didn't deserve having to walk all the way down to medbay proper just to throw away things. Now they can remain in their room forever.
The morgue enjoys a special relationship with robotics, and having to go through the main medbay is also a bit annoying.

Changelog

(u)Tyrant
(+)Genetics in Oshan now has a disposal chute.
(+)Robotics Storage in Oshan now has a door connecting to the morgue directly.

@TheTyrant25 TheTyrant25 requested a review from flrsh as a code owner June 24, 2023 08:38
@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Jun 24, 2023
@keywordlabeler keywordlabeler bot added C-QoL A quality of life improvement that makes the game easier to play E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Jun 24, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2023
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=21415

@TheTyrant25
Copy link
Contributor Author

here's the MapDiffBot2 render for those who are lazy
image

Sord213
Sord213 requested changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@Sord213 Sord213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why two tiny changes needed a forum thread.

Change the access spawner on the morgue -> robotics storage door to robotics access so medical doctors can't loot the robotics storage room

@TheTyrant25
Copy link
Contributor Author

people get sensitive over oshan changes so i wanted to be safe. I'll switch the access in a bit

@TheTyrant25 TheTyrant25 requested a review from Sord213 June 29, 2023 06:00
@Sord213 Sord213 merged commit bcf57c6 into goonstation:master Jun 29, 2023
20 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 29, 2023
@robuddybot
Changelog for #14684 [skip ci]
4499342
@TheTyrant25 TheTyrant25 deleted the oshan-1 branch June 30, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flrsh flrsh Awaiting requested review from flrsh flrsh is a code owner

@Sord213 Sord213 Awaiting requested review from Sord213

Assignees
No one assigned
Labels
A-Mapping A mapping change C-QoL A quality of life improvement that makes the game easier to play E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheTyrant25 @Sord213