Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds mining projectile components, fixes #13570 #14695

Merged

Conversation

RubberRats
Copy link
Contributor

[GAME OBJECTS] [VEHICLES] [BUG] [CODE QUALITY]

About the PR

This PR adds a new component that allows projectiles to mine asteroid tiles, and changes the current mining weapon projectiles to use this new system. This also reopens the possibility for a projectile to mine multiple tiles, which was removed as a side effect of #13324.

Why's this needed?

Fixes #13570, cleans up mining projectiles a bit.

Changelog

(u)RubberRats
(+)Plasma cutters and other mining weapons can break multiple asteroid tiles at once again.

@RubberRats RubberRats requested a review from pali6 as a code owner June 25, 2023 17:03
@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object A-Vehicles Deals with vehicles, including pods, segways, forklifts, and anything else you can ride. C-Bug A bug that impacts usage of a feature C-Code-Quality Cleans up code, refactors things to be more readable or intuitive labels Jun 25, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2023
@ZeWaka ZeWaka merged commit 127b965 into goonstation:master Jul 3, 2023
20 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Vehicles Deals with vehicles, including pods, segways, forklifts, and anything else you can ride. C-Bug A bug that impacts usage of a feature C-Code-Quality Cleans up code, refactors things to be more readable or intuitive size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plasma Cutters dont cut
2 participants