Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes the Pet For the HoP #14790

Closed
wants to merge 4 commits into from

Conversation

Wisemonster
Copy link
Contributor

@Wisemonster Wisemonster commented Jun 30, 2023

[FEATURE] [CRITTER]

About the PR

Places Orwell, the HoP's Atlas pet, across most in-rotation stations.

Why's this needed?

Currently, the HoP is the only head that does not have a standard pet, completely lacking any pet on most in-rotation maps. This pr gives the HoP a standard pet, to reduce confusion when the HoP talks about his pet, and to let him have a pet in general.

Changelog

(u)Wisemonster
(+)The HoP has decided to take his loyal dog Orwell to more stations!

@keywordlabeler keywordlabeler bot added A-Critters Deals with any of our NPC critters - on or off-station. C-Feature A new feature or enhancements to existing features labels Jun 30, 2023
@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Jun 30, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2023
@ThatFiveGuys
Copy link
Contributor

Forcefully removing a persons dogs? This reminds me of a certain book written by a certain someone

@Glamurio
Copy link
Contributor

Glamurio commented Jul 1, 2023

Justice for Blair.

@DisturbHerb
Copy link
Contributor

put blair back!!!

@Wisemonster
Copy link
Contributor Author

Ok, I can either put blair back on Clarion and Oshan, and keep Orwell on every other map, or put Blair on every map, and replace Orwell on Atlas

@DisturbHerb
Copy link
Contributor

to replace is to be scariligeous. there must be balance in the universe. 🐶

@Wisemonster
Copy link
Contributor Author

Ok, I returned Blair to Clarion/Oshan, I could also try to even out which dog is on each station, although that would be difficult to maintain when maps enter/leave rotation.

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jul 2, 2023
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2023
@Wisemonster
Copy link
Contributor Author

Ok, I fucked over this pr real bad, gonna remake it to clear up these conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Critters Deals with any of our NPC critters - on or off-station. A-Mapping A mapping change C-Feature A new feature or enhancements to existing features S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants