Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lanyards to tourist (also adds blob and cow mutantrace) #14807

Merged
merged 2 commits into from Jul 25, 2023

Conversation

Glamurio
Copy link
Contributor

@Glamurio Glamurio commented Jul 1, 2023

[Feature] [Respawning]

About the PR

This PR makes all tourists start with a lanyard in their ID slot, which contains their ID.

It also adds /datum/mutantrace/blob and /datum/mutantrace/cow to its possible mutant races, putting it in line with the Ambassador job.

Why's this needed?

Lanyards are cool, tourists seem like the perfect job for it because they don't start with a PDA.

Changelog

(u)Glamurio (Ryou)
(+)Tourists now spawn with a lanyard containing their ID.

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Jul 1, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2023
@CaioFrancisco
Copy link
Contributor

It also adds /datum/mutantrace/blob and /datum/mutantrace/cow to its possible mutant races, putting it in line with the Ambassador job.

Devilish sneaky change. I've got no problems with it though, and I'm sure it's a welcome change.

@Glamurio
Copy link
Contributor Author

Glamurio commented Jul 1, 2023

Devilish sneaky change. I've got no problems with it though, and I'm sure it's a welcome change.

I didn't mean to be devilish or sneaky, my original intent was to add the lanyards, then I saw someone asking if mutant races might also be added to tourist, and since it's basically the same lines of code I figured I can group it. I'll atomize if necessary, but it just seems really minor that I didn't bother.

@Glamurio Glamurio changed the title Add lanyards to tourist Add lanyards to tourist (also adds blob and cow mutantrace) Jul 1, 2023
@keywordlabeler keywordlabeler bot added the A-Respawning Deals with (re)spawning of mobs. Roundstart, latejoin, events... label Jul 2, 2023
Copy link
Member

@frawhst frawhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@Roninnozlo
Copy link

i hope someone turns blob into an actual mutrace at some point and not just a human with less equip slots, a bad language flag, and a different sprite (that doesn't even fit with equipment overlays)

same with martian... my boys need some love

anyway, a welcome change

@TobleroneSwordfish TobleroneSwordfish merged commit 2beaaff into goonstation:master Jul 25, 2023
23 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Respawning Deals with (re)spawning of mobs. Roundstart, latejoin, events... C-Feature A new feature or enhancements to existing features size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants