Reworks Interdictor Mob Protection #14881

Wisemonster · 2023-07-08T01:26:30Z

[BALANCE] [STATUS EFFECTS] [INPUT WANTED]

About the PR

This pr refactors the interdictor's mob protection effects for wormholes/radstorms/magnetic biofields to a status effect. This also makes it so the interdictor's power drain will be affected by the amount of players in it's AoE, and not be drained whenever someone within the AoE negates a portal/magnetic biofield.

Why's this needed?

Currently, not many people know what interdictors do, and not many people realize that being within an interdictor during a radstorm protects you. This pr aims to make it so that people are more aware that the interdictor protects them from wormholes/radstorms/magnetic biofields, and make it so that the amount of people protected will influence power drain to a degree.

Changelog

(u)Wisemonster
(*)Interdictors will now drain 6u of power per player in their influence
(*)Removed power drain on interdictors from negating worm holes and magnetic biofields
(+)Changed the interdictor protection to be tied to a status effect
(+)Added a particle effect for the interdictor status effect

github-actions · 2023-07-08T01:27:00Z

Created discussion thread: https://forum.ss13.co/showthread.php?tid=21501

Kubius

I think this is a very solid idea overall for intuitive awareness of interdictors' protection functionality - exact power draw values might need tuning, but that's generally the case no matter what you change.

It's been mentioned that the buff could have a small visual effect, and if that's something you're inclined to do I think it might be interesting to have that as a faint golden "aura" underlaid around protected individuals, somewhat sporadic and sparkling in appearance.

Kubius · 2023-07-08T03:24:48Z

code/mob/living/life/disability.dm

-						interdictor_influence = 1
-						break
-				if(!interdictor_influence)
+				if (owner.hasStatus("spatial_protection"))


Removing the radstorm_interdict call here means the baseline cost of interdicting a radstorm (independent of number of protected individuals) doesn't apply. My recommended change to preserve the baseline cost would probably be some functionality inside the main process() to apply that baseline cost if there's a currently active mass radiation event and the interdictor applied at least one protection buff on the last tick; to compensate for the per-user cost, it could probably be reduced slightly as well.

By the main_process(), do you mean for the radstorm, or interdictor?

Ok, so I simply added the radstorm_interdict proc to the end of the interdict proc, and it seems to work. It seems that something is already checking whether or not a radiation storm is going on for the proc. Although as a side effect, it will start draining the increased power when the event is announced, rather than when the radiation hits the station. If this is a problem, I'll try looking for another solution.

Kubius · 2023-07-08T03:26:26Z

code/mob/living/life/disability.dm

-						break
-				if(!interdictor_influence)
+				if (owner.hasStatus("spatial_protection"))
+					return


Returning here prevents the checks further below from happening. Could invert the hasStatus check with ! instead.

Alright, done

Kubius · 2023-07-08T03:29:50Z

code/mob/living/life/Life.dm

+						src.changeStatus("spatial_protection", 3 SECONDS)
+					if (!iscarbon(src)) //Prevents non-carbons from getting the Zephyr stam boost, but still protects other mobs
+						break
+					if (IX.expend_interdict(4,src,TRUE,ITDR_ZEPHYR)) // Zephyr-class interdictor: carbon mobs in range gain a buff to stamina recovery, which can accumulate to linger briefly


As there's now an ongoing cost from having people in range at all, the Zephyr cost could probably be reduced, or skipped entirely (making it simply check for mob's carbon status and interdictor's board type inside of the main expend_interdict). Not vital, but worth considering.

I could do that, although I'm unsure how costly the interdictors are atm, and having one status effect from interdictors drain battery, and not the other could be a bit confusing

Wisemonster · 2023-07-08T15:27:37Z

It's been mentioned that the buff could have a small visual effect, and if that's something you're inclined to do I think it might be interesting to have that as a faint golden "aura" underlaid around protected individuals, somewhat sporadic and sparkling in appearance.

I don't really have enough knowledge with making visual effects to make something more advanced than simply the magnetized aura, but yellow.

Kubius · 2023-07-08T18:27:57Z

That'd probably be good enough, yeah.

ThatFiveGuys · 2023-07-08T19:46:43Z

Good pr, in the long run the effects from the special mainframes should also be status effects but probably outside scope of this pr

Kubius

LGTM. Haven't locally compiled it on my end but appears structurally correct; passive protection draw might need tuning, but that can be done easily down the line, and these values are a solid starting point.

github-actions · 2023-07-25T01:03:17Z

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

TobleroneSwordfish

making interdictors less opaque is good 👍

code/mob/living/life/Life.dm

TobleroneSwordfish · 2023-07-28T04:39:15Z

code/modules/status_system/statusEffects.dm

+	effect_quality = STATUS_QUALITY_POSITIVE
+
+	onAdd(optional=null)
+		owner.add_filter("protection", 1, outline_filter(color="#e6ec21"))


how does this interact with the outline filter for biomagnetic fields?

The biofield outline appears to be closer to the mob than the interdictor outline, but both are visible

Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>

Converts interdictor protection to a status effect

79d4cd0

keywordlabeler bot added A-Status-Effects Deals with status effects of any kind C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Jul 8, 2023

github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2023

Wisemonster changed the title ~~Converts interdictor protection to a status effect~~ Reworks Interdictor Mob Protection Jul 8, 2023

Kubius reviewed Jul 8, 2023

View reviewed changes

Wisemonster added 11 commits July 9, 2023 10:54

Adds status quality

f741b18

Adds visual effect to interdictor status

c93c159

Fixes too early return

3eca7fa

Actually fix this, fr fr

81a7f15

Missed this part of biofields

bc0a236

Bye bye comments

8953d3a

Makes radstorms actually drain power

3f13e9d

Increased by a second to avoid radstorm issues

7071d92

Moves check earlier in proc

4154e30

Minor spelling change

714a685

Removes redundant target var/checks

a73efed

Kubius approved these changes Jul 10, 2023

View reviewed changes

Wisemonster marked this pull request as ready for review July 10, 2023 01:37

github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jul 25, 2023

TobleroneSwordfish requested changes Jul 28, 2023

View reviewed changes

Wisemonster and others added 2 commits July 28, 2023 06:23

Update code/mob/living/life/Life.dm

499cdf1

Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>

Update code/mob/living/life/Life.dm

46a7844

Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>

Wisemonster requested a review from TobleroneSwordfish July 28, 2023 10:42

github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jul 29, 2023

TobleroneSwordfish merged commit 1e592e8 into goonstation:master Aug 5, 2023
21 checks passed

github-actions bot pushed a commit that referenced this pull request Aug 5, 2023

Changelog for #14881 [skip ci]

869a4ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reworks Interdictor Mob Protection #14881

Reworks Interdictor Mob Protection #14881

Wisemonster commented Jul 8, 2023 •

edited

github-actions bot commented Jul 8, 2023

Kubius left a comment

Kubius Jul 8, 2023

Wisemonster Jul 9, 2023

Wisemonster Jul 9, 2023

Kubius Jul 8, 2023

Wisemonster Jul 9, 2023

Kubius Jul 8, 2023

Wisemonster Jul 9, 2023

Wisemonster commented Jul 8, 2023

Kubius commented Jul 8, 2023

ThatFiveGuys commented Jul 8, 2023

Kubius left a comment

github-actions bot commented Jul 25, 2023

TobleroneSwordfish left a comment

TobleroneSwordfish Jul 28, 2023

Wisemonster Jul 28, 2023

Reworks Interdictor Mob Protection #14881

Reworks Interdictor Mob Protection #14881

Conversation

Wisemonster commented Jul 8, 2023 • edited

About the PR

Why's this needed?

Changelog

github-actions bot commented Jul 8, 2023

Kubius left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Wisemonster commented Jul 8, 2023

Kubius commented Jul 8, 2023

ThatFiveGuys commented Jul 8, 2023

Kubius left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 25, 2023

TobleroneSwordfish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Wisemonster commented Jul 8, 2023 •

edited