Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Newspapers #14928

Merged
merged 65 commits into from Sep 8, 2023
Merged

Adds Newspapers #14928

merged 65 commits into from Sep 8, 2023

Conversation

TheTyrant25
Copy link
Contributor

@TheTyrant25 TheTyrant25 commented Jul 13, 2023

[FEATURE] [OBJ]

About the PR

Adds newspapers that can be found lying around, or custom printed by players. They hide your face when you flick them open.
Features:

  • You can roll up newspapers to hold them in one hand, or open them up to hold them two handed and hide your face while you read the article. The opened up newspapers have an inhand sprite that visually blocks the front of your face and the face_visible gets set to false. Of course, you're still recognisable by your hair and clothes, but it's funny and blocks the AI's facial recognition algorithm. Of course, you need to take off your ID to show up as "unknown"
  • Newspaper headlines, contents and publishers are by default randomly generated. Most are currently done by picking from a list in strings/newspapers.txt, with the most focus on headlines at the moment. It can be expanded later to use the phrase log and possibly even use pick_smart_string to construct new random ones based on partial headlines.
  • Newspapers can be printed with the printing press. You can write custom headlines, publishers, and contents, containing whatever you like. Or leave it blank to have it be yhe default random ones. Unlike books, which cost 2 ink and 2 paper, newspapers only cost 1 ink.

Image

image
image outdated, new sprites have been added

Why's this needed?

Excellent opportunities for roleplay. Sitting on a bench hiding behind a newspaper, selling them while wearing a flat cap... can you imagine? Also: a nefarious way for gangs to spread propaganda.

Changelog

(u)Tyrant, Flaborized
(+)Added newspapers! You can open them up to hide your face behind them, and read the headlines. Make some at the printing press!

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Jul 13, 2023
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Jul 13, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2023
@TheTyrant25
Copy link
Contributor Author

TheTyrant25 commented Jul 13, 2023

todo:

  • See if the face covering works
  • Get item sprites
  • Get held sprites. Ideally those that would actually physically block the view of the player's face.
  • Randomly generate headlines
  • Create a way for them to be generated by printing presses.

@zelda4040404
Copy link
Contributor

Would it be at all possible for the newspapers to contain written content as well? I would love to be able to do an actual newspaper gimmick without having to rely on booklets when writing articles.

@TheTyrant25
Copy link
Contributor Author

Possible, yes. Could make them writable like paper is. I was just keeping them headline only to make them simpler, for the random generation aspect. Generating an article that relates to a random headline... is hard. Then again, could have it so that the article itself is optional when making a custom newspaper.

@Glamurio
Copy link
Contributor

Suggestion: Get the printing press involved. They've recently been spread on all stations and would work perfectly for this. Put written paper in press to copy text from, fill it up with empty paper, create newspaper that cannot be edited anymore, but can be mass produced and spread on the station. This opens a cool new journalism branch that the journalist could get involved in.

@TheTyrant25
Copy link
Contributor Author

Excellent idea.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2023
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2023
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Jul 17, 2023
@TheTyrant25
Copy link
Contributor Author

hopefully this fixes things

@TheTyrant25
Copy link
Contributor Author

okay random articles have been implemented

Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprites are still way too big, items should not cover two tiles and clip into the wall next to them

@TheTyrant25
Copy link
Contributor Author

ah i have some new sprites which were made but haven't included them yet

Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The face blocking doesn't seem to work?
image
also nitpick but it'd be neat if the headline was added to the content of the newspaper with header styling, since hiding it in the examine text is a bit obscure

@TheTyrant25
Copy link
Contributor Author

well, that's an issue.

@TheTyrant25
Copy link
Contributor Author

okay so i've fixed it and it now works as long as the person isn't wearing their ID. Which is how stuff like welding masks works too. very close to completion now. Just trying to fix one last bug where the article is always a handwritten one.

@TheTyrant25
Copy link
Contributor Author

fixed the issues with articles not generating right and it's now good to go
the only thing left to fix is automatically generating articles that are grammatically correct. Which i will not be doing because it's hard.

@TobleroneSwordfish TobleroneSwordfish merged commit 2d80098 into goonstation:master Sep 8, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
@TheTyrant25 TheTyrant25 deleted the newspaper branch September 8, 2023 14:28
@DisturbHerb
Copy link
Contributor

everythimg is brokegn

@TheTyrant25
Copy link
Contributor Author

TheTyrant25 commented Sep 8, 2023

?
edit:
!

@TheTyrant25 TheTyrant25 added the E-Add-To-Wiki A PR that will require changes to the wiki label Dec 15, 2023
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants