Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various Mulebot things #14983

Merged
merged 3 commits into from Jul 21, 2023
Merged

Fix various Mulebot things #14983

merged 3 commits into from Jul 21, 2023

Conversation

TheTyrant25
Copy link
Contributor

@TheTyrant25 TheTyrant25 commented Jul 17, 2023 •
edited by ZeWaka

[MAPPING] [MINOR] [QOL]

About the PR

  • Unswaps the Donut2 Medbay and Hydroponics beacons.
  • Makes the mulebot tooltip holder "set destination" use a dropdown menu like in the pda
  • Makes it so that destinations are scanned automatically when you open the PDA app (you can still rescan them ofc)
  • removed a load of empty lines that were there for no reason

Why's this needed?

Mulebots are somewhat neglected. What would wisemonster say? We should give them a bit more care.

Changelog

(u)Tyrant
(+)The mulebot's destinations are now scanned automatically when opening the menu and displayed as a list.

@keywordlabeler keywordlabeler bot added A-Mapping A mapping change C-QoL A quality of life improvement that makes the game easier to play P-Minor A bug that does not impact usage of a feature. These are often visual issues labels Jul 17, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2023
@ZeWaka
Copy link
Member

ZeWaka commented Jul 20, 2023

Please condense into a single changelog entry

@TheTyrant25
Copy link
Contributor Author

Please condense into a single changelog entry

done

@TheTyrant25 TheTyrant25 requested a review from ZeWaka July 21, 2023 05:33
@ZeWaka
Copy link
Member

ZeWaka commented Jul 21, 2023 •
edited

More like

(+)The mulebot's destinations are now scanned automatically when opening the menu and displayed as a list.

:feelsgood:

@ZeWaka ZeWaka merged commit 4ab8fd6 into goonstation:master Jul 21, 2023
26 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 21, 2023
@robuddybot
Changelog for #14983 [skip ci]
f906a2e
@TheTyrant25 TheTyrant25 deleted the muletime branch July 21, 2023 23:52
@TheTyrant25 TheTyrant25 mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sord213 Sord213 Awaiting requested review from Sord213 Sord213 is a code owner

@mordent-goonstation mordent-goonstation Awaiting requested review from mordent-goonstation mordent-goonstation is a code owner

@ZeWaka ZeWaka Awaiting requested review from ZeWaka

Assignees
No one assigned
Labels
A-Mapping A mapping change C-QoL A quality of life improvement that makes the game easier to play P-Minor A bug that does not impact usage of a feature. These are often visual issues size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheTyrant25 @ZeWaka