Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes to the trickster's runetrap #14988

Merged

Conversation

Bartimeus973
Copy link
Contributor

About the PR

Fixes an oversight that allows intangible mobs (such as the ai eye) to trigger trickster traps.
Adds an unreferenced slipperiness trap that i thought i added in #11195
Turns out i never added it to the list, so i added it for real this time.

Also removes the elecflash the slipperiness trap had and instead write a specific message in the chat of the slipped person so the trap isnt immediatly obvious. Other behaviors remain unchanged.

Why's this needed?

Mostly bugfixing.

Changelog

(u)Bartimeus973
(+)Trickster wraith can now spawn a slippery runetrap. Intangible mobs no longer trigger the runetrap.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2023
@Bartimeus973 Bartimeus973 added C-Bug A bug that impacts usage of a feature A-Game-Objects The point of this PR is to deal with a specific game object size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2023
@TobleroneSwordfish TobleroneSwordfish merged commit 11cdb36 into goonstation:master Jul 18, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 18, 2023
@Bartimeus973 Bartimeus973 deleted the runetrap_immaterial branch July 18, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Bug A bug that impacts usage of a feature size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants