Fixes: Code-Typos in MechComp Refactor #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoops
Wasn't paying enough attention at the time
keywordlabeler
bot
added
the
P-Major
MarkNais
added
the
E-DNM
|
Telecomp issue found, one moment |
Wasn't paying enough attention at the time
MarkNais
removed
the
E-DNM
|
investigated, fixed, and tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MAJOR]
About the PR
Fixes my typo in the PNetComp - it wasn't forwarding any messages on from PNet to MechComp.
When using "Disconnect All" on a MechComp device, it was saying that it was disconnecting the component datum, instead of the device name. Purely visual typo, behavior was otherwise proper.
Fixes the teleporter component not accepting new ID's through MechComp messages
Both changes tested.
Why's this needed?
PNetcomp and Telecomp are major bugs (per label definition)
Disconnect was trivial.