Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the syndicate megaphone from surplus crates #15136

Merged
merged 2 commits into from Aug 13, 2023

Conversation

unfunnyperson
Copy link
Contributor

@unfunnyperson unfunnyperson commented Jul 27, 2023

About the PR

Prevents the black market megaphone from appearing in surplus crates.

Why's this needed?

Joke items are blacklisted from surplus crates. Why isnt this one blacklisted?

Changelog

(u)UnfunnyPerson
(+)The black market megaphone can no longer be found in surplus crates.

[GAME OBJECTS] [REMOVAL]

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2023
@CaioFrancisco
Copy link
Contributor

CaioFrancisco commented Jul 27, 2023

The spy menu should still contain some fluff, specially if it used by the antags. The spies get an enormous menu of things they can redeem for toys, anyway, they can simply choose to not get it.

@unfunnyperson
Copy link
Contributor Author

readded to spy

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Removal Removal of an existing feature labels Jul 28, 2023
@unfunnyperson unfunnyperson changed the title Removes the syndicate megaphone from surplus crates and spy bounties Removes the syndicate megaphone from surplus crates Jul 28, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Aug 12, 2023
@Tarmunora Tarmunora merged commit d889d3a into goonstation:master Aug 13, 2023
26 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 13, 2023
@unfunnyperson unfunnyperson deleted the nojokeitemsinspy branch August 14, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Removal Removal of an existing feature S-Stale An inactive PR that has had no updates in the past two weeks size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants