Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGUI Cryo Pod #15152

Merged
merged 15 commits into from Aug 14, 2023
Merged

TGUI Cryo Pod #15152

merged 15 commits into from Aug 14, 2023

Conversation

Garash2k
Copy link
Contributor

@Garash2k Garash2k commented Jul 28, 2023

About the PR

Updates the Cryo Pod HTML UI into TGUI

There's one functional change that could be atomized or undone if it's controversial: being unable to press buttons while inside the pod (How can the spaceman hit the zap button or remove the beaker while inside the pod!)

Without upgrades
image

With upgrades (Health analyzer and Defib) (note: radiation, brain damage, and implants still show up without upgrades, the user just didn't have any in the previous screenshot)
image

While outside
image

Old UI
image

Why's this needed?

Forums wanted it! (It was on my shortlist too though!)
TGUI good

Changelog

(u)Garash
(+)New UI for the Cryo Pods

[UI][Feature]

@boring-cyborg boring-cyborg bot added the A-UI Modifies UI in some way. Automatically applied on a change to tgui/ label Jul 28, 2023
@keywordlabeler keywordlabeler bot added A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Feature A new feature or enhancements to existing features labels Jul 28, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 28, 2023
@Garash2k Garash2k marked this pull request as ready for review July 29, 2023 05:02
@ZeWaka ZeWaka added the C-Rework Reworks a feature label Jul 29, 2023
tgui/packages/tgui/interfaces/CryoCell.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/CryoCell.js Outdated Show resolved Hide resolved
code/modules/atmospherics/machinery/unary/cryo_cell.dm Outdated Show resolved Hide resolved
@DisturbHerb
Copy link
Contributor

This interface seems way too big for how much information it displays, I think.

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Aug 1, 2023
@Garash2k
Copy link
Contributor Author

Garash2k commented Aug 5, 2023

Cryo pods and health scan (without the organ uprade) don't tell you about missing or hurt organs, but they do warn you about cyberorgans "Unknown augmented organs detected." New UI should try to do the same

@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2023
@Garash2k
Copy link
Contributor Author

"Unknown augmented organs" indicator that was previously in health_scan added
image

@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Aug 11, 2023
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Aug 13, 2023
@TobleroneSwordfish TobleroneSwordfish merged commit b34cd32 into goonstation:master Aug 14, 2023
21 checks passed
@TobleroneSwordfish
Copy link
Contributor

checks are for cowards

github-actions bot pushed a commit that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Feature A new feature or enhancements to existing features C-Rework Reworks a feature S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants