Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pronouns to human examine text #15178

Merged
merged 3 commits into from Aug 3, 2023

Conversation

CaioFrancisco
Copy link
Contributor

@CaioFrancisco CaioFrancisco commented Jul 30, 2023

About the PR

Simple change, right? One line, just a quick browse around the code and you find all the important bits to make this feature work. Well, because I'm a great coder, it took me 40 minutes to do because I had to browse Youtube for something that works as background noise, and I kept getting interrupted every 5 or 10 minutes. Anyway,

this PR adds pronouns to the examine text. This will make pronouns easier to see, as you don't have to squint on the examine mouse-over text, nor you have to discover the examinee's pronouns by bits through the "person seems to have something on their head."

Why's this needed?

Pronouns should be easier to notice and memorize, and keeps getting expanded with the cyborg pronouns suggestion thread on the forums, which got a pretty big traction after only having just a day of existing.

Examples

Screenshot_770
Screenshot_769

Changelog

(u)Caio029
(+)Pronouns will now be shown on the examine text of humans.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2023
@CaioFrancisco CaioFrancisco added C-QoL A quality of life improvement that makes the game easier to play A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities labels Jul 30, 2023
@CaioFrancisco
Copy link
Contributor Author

Linked to some examples of the examine text.

@ZeWaka
Copy link
Member

ZeWaka commented Aug 1, 2023

Why not just do you look closely at XYZ XYZ (they/them)

@CaioFrancisco
Copy link
Contributor Author

Why not just do you look closely at XYZ XYZ (they/them)

I'd like to make it so the pronouns and the name are in separate lines, to avoid possible confusion, but I can do that.

@ZeWaka ZeWaka merged commit fcc5015 into goonstation:master Aug 3, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-QoL A quality of life improvement that makes the game easier to play size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants