Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprites Robuddies #15188

Merged
merged 3 commits into from Aug 5, 2023
Merged

Conversation

Mister-Moriarty
Copy link
Contributor

@Mister-Moriarty Mister-Moriarty commented Jul 30, 2023

[Game Objects] [Sprites]

About The PR:

PR-1, 3, 4, 6, and 7 robuddies, the robuddy types currently ingame, have been resprited to match modern spriting standards. Additionally resprites robuddy frames and robuddy charging docks.
Most sprites are based upon Erin's robuddy sprites, published in #723 and later reverted in #753.
Regarding the aforementioned reversion, Flourish has given assent for a second resprite.

Robuddies.mp4

Mailbuddies, goldenbuddies, xmasbuddies, Hemera's secbuddies, and Evengy now use "skin" overlays to recolour their frames, as opposed to an entirely separate icon file.

image

Robuddy lights have refactored into overlays.
Robuddy hats now make use of the existing human sprites for worn hats, offset to fit the robuddy sprites.
Deprecates the icon_needs_update variable.
Temporarily removes the mostly unused costumes, pending a refactor.

Does not resprite Super Protector Friend IIIs - I have however reorganised their sprites to be compatible with the new backend code for robuddy faces and lights.

Does not resprite Gerhazo's mob robuddies, as they use their own specific set of sprites for conveying emotes.

Please notify me if I have missed a guardbot subtype or object using robuddy sprites. This project has spanned almost two months, and despite my best efforts, I have most definitely missed something somewhere.

Why Is This Needed?

Parity with modern spriting standards.

Changelog:

(u)Mr. Moriarty & Erinexx
(+)Resprited robuddies.

@keywordlabeler keywordlabeler bot added the A-Game-Objects The point of this PR is to deal with a specific game object label Jul 30, 2023
@boring-cyborg boring-cyborg bot added A-Mapping A mapping change C-Sprites Automatically applied on any .dmi or icons folder change labels Jul 30, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 30, 2023
Copy link
Contributor

@TheTyrant25 TheTyrant25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little confused on why you made skin_icon_state instead of just using the normal icon state, but i'm sure there's a good reason for it. lgtm

@Mister-Moriarty
Copy link
Contributor Author

a little confused on why you made skin_icon_state instead of just using the normal icon state, but i'm sure there's a good reason for it. lgtm

Skin overlays are separate to the robuddy bodies so that they may be reused for robuddy frames. See the goldenbuddy's frame.

code/modules/robotics/bot/guardbot.dm Outdated Show resolved Hide resolved
@ZeWaka ZeWaka merged commit 5a5f494 into goonstation:master Aug 5, 2023
22 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 5, 2023
@Mister-Moriarty Mister-Moriarty deleted the robuddy-resprite branch August 6, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Mapping A mapping change C-Sprites Automatically applied on any .dmi or icons folder change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants