Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't store state on material trigger procs #15205

Merged
merged 2 commits into from Aug 8, 2023
Merged

Don't store state on material trigger procs #15205

merged 2 commits into from Aug 8, 2023

Conversation

amylizzle
Copy link
Contributor

@amylizzle amylizzle commented Aug 1, 2023 •
edited

About the PR

Moves molitz and plasma state stuff to the material props instead.

Note this slightly changes the behaviour of molitz and plasmastone.

Why's this needed?

Clean. Bad practice to store it on the triggers because it violates the whole mutability thing.

(u)Amylizzle
(+)Plasmastone now releases its plasma somewhat slower. You can see how much plasma is left using a material analyzer.
(+)You must now use the material analyzer to see how much gas is left in Molitz and Molitz Beta.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2023
@amylizzle amylizzle added C-Code-Quality Cleans up code, refactors things to be more readable or intuitive A-Materials Deals with our materials system in some way labels Aug 1, 2023
@amylizzle amylizzle marked this pull request as ready for review August 1, 2023 20:03
@TobleroneSwordfish TobleroneSwordfish merged commit 57527f5 into goonstation:master Aug 8, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 8, 2023
@robuddybot
Changelog for #15205 [skip ci]
a127424
@amylizzle amylizzle deleted the don't-store-those-there branch August 8, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeWaka ZeWaka ZeWaka approved these changes

Assignees
No one assigned
Labels
A-Materials Deals with our materials system in some way C-Code-Quality Cleans up code, refactors things to be more readable or intuitive size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amylizzle @ZeWaka @TobleroneSwordfish