Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latejoining Stowaways, Pilots, and Heavy Sleepers no longer get announced #15240

Merged
merged 2 commits into from Aug 6, 2023

Conversation

MintyPhresh
Copy link
Contributor

About the PR

Makes the announcement computer not announce characters who have ostensibly been on the station for the whole shift, or who aren't on the station.

Why's this needed?

Doesn't make sense for the announcement computer to be all-knowing about stowaways & pilots, and heavy sleepers have been on station all shift. Makes things like undercover secasses possible for non-roundstart players.

(u)Mintyphresh
(+)Latejoining players with the Stowaway, Pilot, or Heavy Sleeper trait will no longer be announced.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2023
@M-Earthfire
Copy link
Contributor

I really like that. Also makes validhunting salvagers via metagaming harder when one of them tries to infiltrate the station.

@CaioFrancisco
Copy link
Contributor

It feels like there should be a points re-arrangement for the traits (except maybe stowaway), then. Coming in dark on the station has it's enormous plus, specially if you are an antagonist.

@MintyPhresh
Copy link
Contributor Author

MintyPhresh commented Aug 4, 2023

It feels like there should be a points re-arrangement for the traits (except maybe stowaway), then. Coming in dark on the station has it's enormous plus, specially if you are an antagonist.

It's definitely a massive boost, and something to seriously consider... But you can "join dark" by just getting in at the start of the round, maybe finding a hiding spot and going AFK. Only difference I can foresee for that is that Heavy Sleepers will be hidden from the manifest. I'm not sure changing point costs is necessary

@ZeWaka ZeWaka added C-Rework Reworks a feature A-Respawning Deals with (re)spawning of mobs. Roundstart, latejoin, events... labels Aug 6, 2023
@ZeWaka ZeWaka merged commit 4535851 into goonstation:master Aug 6, 2023
23 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 6, 2023
@Sbmhawk
Copy link
Contributor

Sbmhawk commented Aug 6, 2023

I don't see why heavy sleepers should be excluded from the manifest. Stowaways and pilots sure, as I don't believe they are technically NT employees, but that does not apply to heavy sleepers.

@MintyPhresh
Copy link
Contributor Author

Oh, yeah, no, they're on the manifest after they join, there's just no way for the manifest to know that beforehand

@MintyPhresh MintyPhresh deleted the stowawayannounce branch August 13, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Respawning Deals with (re)spawning of mobs. Roundstart, latejoin, events... C-Rework Reworks a feature size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants