Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds chili cheese fries #15262

Merged
merged 4 commits into from Sep 16, 2023
Merged

Adds chili cheese fries #15262

merged 4 commits into from Sep 16, 2023

Conversation

Glamurio
Copy link
Contributor

@Glamurio Glamurio commented Aug 6, 2023

About the PR

Adds /datum/cookingrecipe/chilifries (made with fries) and /datum/cookingrecipe/chilifries_alt (made with chips), which produce /obj/item/reagent_containers/food/snacks/chilifries, a new food that contains some capsaicin and cheese.

Why's this needed?

Mhhh, yummy

Changelog

(u)Ryou (Glamurio)
(+)Adds chili cheese fries. Yummy!

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Aug 6, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2023
@Bartimeus973 Bartimeus973 added C-Feature A new feature or enhancements to existing features A-Game-Objects The point of this PR is to deal with a specific game object A-Catering Deals with food, the chef, the bar or otherwise edible/drinkable stuff labels Aug 6, 2023
@Glamurio
Copy link
Contributor Author

Glamurio commented Aug 6, 2023

Apologies for the lack of tagging, thanks Bartimeus, I just kind of tossed this PR out

Copy link
Contributor

@flrsh flrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sprite needs more work. Right now it looks like fries with some globs of ketchup. Maybe consider shifting the color of the fries as a whole? Or adding a pattern to the wrapper.

@Glamurio
Copy link
Contributor Author

The sprite needs more work. Right now it looks like fries with some globs of ketchup. Maybe consider shifting the color of the fries as a whole? Or adding a pattern to the wrapper.

Got a new sprite, this one's without wrapper and looks more like a prepared dish similar to other prepared dishes, ideally served on a plate.
image

@Glamurio Glamurio requested a review from flrsh August 15, 2023 01:44
@deathrobotpunch
Copy link
Contributor

THANKS ALOT I AM HUNGRY NOW

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Aug 30, 2023
@pali6
Copy link
Member

pali6 commented Aug 30, 2023

According to sprite-knowledgeable devs and admins the sprites are eh.

@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Aug 31, 2023
@Glamurio
Copy link
Contributor Author

According to sprite-knowledgeable devs and admins the sprites are eh.

Rejoice, for the gods have bestowed upon us a new sprite. Credits to waffleloffle
image

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Sep 15, 2023
@frawhst frawhst merged commit f7ba196 into goonstation:master Sep 16, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Catering Deals with food, the chef, the bar or otherwise edible/drinkable stuff A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change S-Stale An inactive PR that has had no updates in the past two weeks size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants