Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vending machines can be shot over when tipped, and shot to be tipped over #15273

Merged
merged 40 commits into from Aug 15, 2023

Conversation

MeggalBozale
Copy link
Contributor

@MeggalBozale MeggalBozale commented Aug 6, 2023

[Game-Objects] [Balance]

About the PR

Vending machines can be tipped over when shot with a probability equal to bullet power (60% for pred revolver, for example)

Why's this needed?

Nuke Ops can't really work around vending machines as they can't be reasonably expected to deconstruct them, so this solves that issue. Also, just makes sense

dreamseeker_qiifX19KbL

Changelog

(u)MeggalBozale
(+)Vending machines can be tipped over by shooting them, and shooting them when tipped over lets bullets move past.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2023
@MeggalBozale
Copy link
Contributor Author

OK whoops different approach now after conversation in imcoder

@MeggalBozale MeggalBozale changed the title Allow vending machines to be destroyed by force (& slightly more) Vending machines can be shot over when tipped, and shot to be tipped over Aug 6, 2023
@MeggalBozale
Copy link
Contributor Author

Outside of the name of this PR, but I think there's some other things that need adjusting too. Namely:

Things I think should be shootable over

KitchenHelper
Microwave
Processor
Oven
Deep Fryer
Stove
Espresso Machine
Vending Machines (PR'd already)
Freezer
TEG
Furnace
Portable Air Scrubber
Air Pump
Portable Reclaimer
Artifact lab machines
Hydrophonics trays
Aquatic Research Pool
Material Processor
Nanofabs
Electroplater
Ruckingeur kit
monkeyplant
piano
loudspeaker
crematorium
coffins (act like lockers RN, but IMO too short for that to be reasonable)
morgue slabs
tray

Things I think should be destroyable via shooting

Consoles (Gene, QM, etc.)
Cloning (iffy there ey)
SMES
Foamtank/Fueltank/etc (all fluid tanks)
Scanner (same method as printer)
Chem dispenser (REALLY iffy, could shoot over too but feels too tall)
Reagent heater
Fishing Supplies Vendor (tip over like vendor?)
Aquatic Research Upload Terminal (tip over like vendor?)
Arcade machine
Cryogenic Healing pod
Compact Sleeper
Cyborg Docking Station
Gene booth (tip over like vendor?)
GeneTek Scanner
Tank Storage Unit
Disposals Outlet
Records cabinets (or shoot past, but mmmm)
Water cooler (or shootable over, with first few shots knocking off the jug and then shootable over)

I got these objects by running around as a machine gunner on Atlas and shooting everything in sight. Foolproof.
Objects I think should be destroyable would need varying amounts of health, which would probably require discussion

@keywordlabeler keywordlabeler bot added the C-Balance Balance changes, buffs and nerfs label Aug 7, 2023
code/modules/vending/vending.dm Outdated Show resolved Hide resolved
@Tarmunora Tarmunora merged commit f7073e9 into goonstation:master Aug 15, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@MeggalBozale MeggalBozale deleted the destruct branch August 15, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants