New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds unique PDA emergency alert variants (font color, jingle) #15326
Conversation
that font is pretty unreadable |
i would also like a medical alert module for medic pda’s |
and the font has always been unreadable |
Yeah, I was going to mention. The font hasn't been changed, just the color. |
I think only dedicated modules should get the big alert text, but different jingles are very good. A key difference to me is that PDA Program alert can be issued by any random crew member, and PDA Module alert is (presuming no theft) a person asking their team for backup. This is why the alert button is worth sacrificing a PDA flashlight for - as Security, you have a button that tells the rest of Security shit's fucked. Other non-sec crew around you can hear/see/react to security calling security for help. Adding a medical alert module and engineering alert module ala the security ones but placing them in their respective equipment vendors makes sense, and can use the jingles/text. It would be a good default for the Medical Doctor PDAs too, I think. |
i just think it's funny when i call for a janitor and everyone looks at me funny |
Where are these sound effects sourced from? |
They're royalty free sound effects sourced from, Pixabay, TunePocket and FreeSound. I've then tweaked some of the sounds to make them more fitting. Should all be legal under Creative Commons. |
Explicitly crediting the sources is best practice, especially for reviewers. |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since these are CC-BY licensed sounds, you need to provide attribution. please attribute all sounds in the description.
Okay, I goobered and lost the original links, but by spending a few hours browsing my search history, I managed to find the exact files in question: Engineering Alert: All three of them were slightly altered in either pitch or speed to be more fitting. PixaBay License: FreeSound ToS: |
[Objects] [QoL] [Rework]
About the PR
This adds proper distinction between all alert variants in the game. Every alert now has a unique font associated with the department that the alert is for, as well as a new jingle to differentiate it from the Security alert, which has been unchanged.
Engineering Alert:
https://pixabay.com/sound-effects/red-alert-nuclear-buzzer-99741/
Medical Alert:
https://freesound.org/people/SpliceSound/sounds/369848/
Janitor Alert:
https://freesound.org/people/milton./sounds/81165/
All three of them were slightly altered in either pitch or speed to be more fitting.
PixaBay License:
https://pixabay.com/service/license-summary/
FreeSound ToS:
https://freesound.org/help/tos_web/
Why's this needed?
To avoid confusion about the kind of alert that has been sent in any given situation.
Changelog