Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make click dragging an item onto a stored HUD equip it #15381

Merged
merged 2 commits into from Aug 18, 2023

Conversation

FlameArrow57
Copy link
Contributor

@FlameArrow57 FlameArrow57 commented Aug 14, 2023

[GAME OBJECTS][QoL]

About the PR

This PR makes it so that click dragging an item stored in a storage HUD onto the HUD location where it's stored will equip it

Why's this needed?

When you are trying really fast to equip an item, it's common that instead of just clicking the item, you will click the item, hold left mouse button, and release when it's on the HUD where it's stored which won't equip it, making you think you never clicked it or some bug happened. This makes it so that doing so will actually equip it instead of doing nothing.

Changelog

(u)FlameArrow57
(+)Improved item equip consistency when equipping an item from your inventory with fast mouse flicks.

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play labels Aug 14, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2023
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may as well make it work for unequipping too for consistency

code/datums/hud/storage.dm Show resolved Hide resolved
@FlameArrow57
Copy link
Contributor Author

FlameArrow57 commented Aug 15, 2023

Can you clarify? Not seeing any issues with unequipping

@TobleroneSwordfish
Copy link
Contributor

Click dragging to hand didn't seem to work for unequipping? I know it's specifically coded for backpacks but it makes sense to be general if we're doing this.

@FlameArrow57
Copy link
Contributor Author

FlameArrow57 commented Aug 16, 2023

I see what you're saying, but point of the PR was to just fix the one issue that's in the description, click dragging items to hand to equip them is a different thing

I'm confused about the need to implement click dragging items from storage to your hand when you can just click them to do so, in this PR?

@TobleroneSwordfish TobleroneSwordfish merged commit e4621ff into goonstation:master Aug 18, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 18, 2023
@FlameArrow57 FlameArrow57 deleted the item-drag branch August 18, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-QoL A quality of life improvement that makes the game easier to play size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants