Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random gang member selection at roundstart #15458

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

pali6
Copy link
Member

@pali6 pali6 commented Aug 20, 2023

About the PR

Turns on the experimental toggle that makes gang member selection random and disables recruitment. Essentially this acts as if every gang leader immediately recruited random people to their gang. Gang member names and jobs will be in chat once you spawn. Gang name is shown to you when the leader chooses it, similarly the locker location is shown to you when the leader places it.

For now this PR exists just as a temporary test merge to test the waters on the idea. I don't plan on merging it unless there's positive feedback on this.

Why's this needed?

Recruitment leads to weird meta strategies of picking only the most "robust" people on classic and to awkwardness of having to justify why your character would join a gang on RP. I'd like to try out this alternative idea and see how it holds up.

Changelog

(u)pali
(*)Experiment: Gang members are recruited randomly at roundstart instead of being recruited manually.<br>Give feedback <a href="https://forum.ss13.co/showthread.php?tid=21701">here</a>.

@pali6 pali6 added E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. A-Gamemodes Changes or additions to any gamemode's main features labels Aug 20, 2023
@pali6 pali6 requested a review from Kyle2143 as a code owner August 20, 2023 18:05
@pali6 pali6 marked this pull request as draft August 20, 2023 18:05
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2023
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=21701

@pali6
Copy link
Member Author

pali6 commented Aug 20, 2023

Reminder to self: For the duration of this experiment gang mode weight in being picked has been increased in https://github.com/goonstation/goonstation-secret/commit/1b1631f55824f360e2ac60e331227026598ee352, revert that after this experiment ends in one direction or the other.

@TobleroneSwordfish TobleroneSwordfish marked this pull request as ready for review September 29, 2023 19:58
@TobleroneSwordfish TobleroneSwordfish merged commit f510d8d into master Sep 29, 2023
74 checks passed
@TobleroneSwordfish TobleroneSwordfish deleted the random-gangs-experiment branch September 29, 2023 19:58
github-actions bot pushed a commit that referenced this pull request Sep 29, 2023
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Sep 30, 2023
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gamemodes Changes or additions to any gamemode's main features C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants