Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to repair damaged windows with sheets of the same material #15493

Merged
merged 6 commits into from Aug 28, 2023

Conversation

unfunnyperson
Copy link
Contributor

@unfunnyperson unfunnyperson commented Aug 23, 2023

[GAME OBJECTS] [PLAYER ACTIONS]

About the PR

Adds the ability to repair damaged windows by clicking on them with sheets of the same material this takes 4 seconds but can be reduced to 2 if the user has carpenter or engi training

Why's this needed?

The current ways to repair a damaged window are either silicate(which ruins the color of the window) or tearing down and replacing the window(griefs the atmosphere).

Adding a non-intrusive way to repair station windows would make repairs a lot less tedious to do.

Changelog

(u)UnfunnyPerson
(+)Clicking a damaged window with a sheets of the same material will repair the window

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities labels Aug 23, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2023
Copy link
Member

@Tarmunora Tarmunora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes let me just glue another pane of glass on the window. That ought to fix it

code/obj/window.dm Outdated Show resolved Hide resolved
@Azrun
Copy link
Contributor

Azrun commented Aug 25, 2023

I think this really interferes with the function of silicate for something that seems be described as a vanity QoL. I'd prefer the actionbar duration was longer but also factors in hasTrait("carpenter") and hasTrait("training_engineer").

@MeggalBozale
Copy link
Contributor

I spun up a bit of discussion in imcoder, perhaps a weldingtool would make more sense for this situation.
Link to the discussion so you can take a look

@Azrun
Copy link
Contributor

Azrun commented Aug 25, 2023

I think I prefer the idea of the small silicate dispenser that can be refilled and improve connection to chemistry. Use of welder to reduce or minimize visual effect of silicate might be cool as well.

@NightmareChamillian
Copy link
Contributor

Big disagree on @Azrun 's silicate idea. Engineers already have far, far too many things they have to carry, and adding another is just going to result in it going unused.

A welding tool or, by going the C:DDA route, soldering iron could work, but I also think the use of glass sheets is fine. It fits in with some of the more cartoony things that can happen, and makes sense, given the fact that engineers are likely to already be carrying them in the event that windows are broken/damaged.

@unfunnyperson unfunnyperson changed the title Adds the ability to repair damaged windows with sheets of the same material. Adds the ability to repair damaged windows with a welder Aug 26, 2023
@Azrun
Copy link
Contributor

Azrun commented Aug 26, 2023

I meant that I preferred the idea discussed in imcoder, wasn't my idea. I don't think engineers have to carry around everything. They could be a tool that is available. That is what makes those carts handy.

I like the idea of slapping the glass on top better than this, I feel like glass is a more limited resource. My understanding is that's isn't even a very feasible thing to do and could damage the glass further.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2023
@unfunnyperson unfunnyperson changed the title Adds the ability to repair damaged windows with a welder Adds the ability to repair damaged windows with sheets of the same material Aug 26, 2023
@Azrun Azrun merged commit cb11283 into goonstation:master Aug 28, 2023
23 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants