Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TGUI color picker to character creation #15506

Merged
merged 3 commits into from Aug 29, 2023

Conversation

Glamurio
Copy link
Contributor

[QoL] [UI] [Rework]

About the PR

Converts the color picker in character creation to TGUI, using a heavily modified version of

https://github.com/omgovich/react-colorful/ (MIT License, copyright and liability statements included in code)

This was made largely made possible by utilizing a lot of existing color picker code from this PR:

BeeStation/BeeStation-Hornet#9417

Why's this needed?

The current color picker is, in my knowledge, the default Windows color picker. This works most of the time, but is clunky, and prone to errors for some people. The new one is not only sleek and easy to use, but also modifiable and much more versatile, and will allow us to limit color selections by palettes or other restrictions in the future.

Changelog

(u)Glamurio (Ryou)
(*)Added TGUI to the character creation color pickers.

@keywordlabeler keywordlabeler bot added A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-QoL A quality of life improvement that makes the game easier to play C-Rework Reworks a feature labels Aug 23, 2023
@boring-cyborg boring-cyborg bot added the A-UI Modifies UI in some way. Automatically applied on a change to tgui/ label Aug 23, 2023
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 23, 2023
@Azrun
Copy link
Contributor

Azrun commented Aug 24, 2023

Was permission granted to re-license the non-MIT aspects?

@Glamurio
Copy link
Contributor Author

Was permission granted to re-license the non-MIT aspects?

According to @ZeWaka we have permission.

@ZeWaka
Copy link
Member

ZeWaka commented Aug 24, 2023

Was permission granted to re-license the non-MIT aspects?

According to @ZeWaka we have permission.

To clarify:
They were not granted a relicense under our license, but under MIT. So, license headers will need to be added.

@ZeWaka ZeWaka added the E-DNM [Dev Only] Do Not Merge - can only be removed by the applier or with their explicit permission. label Aug 24, 2023
@Glamurio Glamurio requested a review from Azrun August 25, 2023 22:12
@ZeWaka ZeWaka removed the E-DNM [Dev Only] Do Not Merge - can only be removed by the applier or with their explicit permission. label Aug 27, 2023
@ZeWaka ZeWaka merged commit 79e0293 into goonstation:master Aug 29, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
@Sovexe
Copy link
Contributor

Sovexe commented Aug 29, 2023

Seeing a few bugs since the merging of PR

  • there is now a color.js and color.ts, and both export a Color class
  • some uses of colors such as the interaction eye and font using style such as good bad average are no longer working on local servers
  • interface not found errors occurring on live when trying to use the color selector modal
  • generic.scss while not included is missing two lines from the beestation original which cause it to fail to build when included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-QoL A quality of life improvement that makes the game easier to play C-Rework Reworks a feature size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants