Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twirl knife to flick off the blood #15554

Merged
merged 12 commits into from Sep 13, 2023
Merged

Conversation

TheTyrant25
Copy link
Contributor

@TheTyrant25 TheTyrant25 commented Aug 28, 2023

[FEATURE]

About the PR

Adds the ability to flick blood off knives and onto the floor. Performed by using the twirl emote. Forensic traces still remain though.

Currently added to kitchen knives, all swords, and syndicate butcher knives.

Why's this needed?

It's a fun little thing that could be used in rp for extra drama. For classic, you can think of it as wiping it off on a shirt.

Changelog

(u)Tyrant
(+)Twirling a bloody knife will flick the blood off and onto the floor. Doesn't work if the blood is dried.

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Aug 28, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2023
@TheTyrant25 TheTyrant25 added A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities A-Game-Objects The point of this PR is to deal with a specific game object labels Aug 28, 2023
@Glamurio
Copy link
Contributor

Please also add this to katanas.

@TheTyrant25
Copy link
Contributor Author

i forgot about them, good point. Anything else that should have this? and should i componetize it?

@Glamurio
Copy link
Contributor

i forgot about them, good point. Anything else that should have this? and should i componetize it?

Honestly, if you're willing to make this a feature, you might as well add this to any kind of bladed weapon. Ideally it would be cool if you could only do this if the blood is fresh and not dried, but I don't know if "blood freshness" gets tracked on a blade.

@TheTyrant25
Copy link
Contributor Author

it doesn't seem like it does, no. I can add it though.

code/datums/components/bloodflick.dm Outdated Show resolved Hide resolved
code/datums/components/bloodflick.dm Outdated Show resolved Hide resolved
TheTyrant25 and others added 2 commits September 12, 2023 22:08
Co-authored-by: aloe <frawhstdev@gmail.com>
Co-authored-by: aloe <frawhstdev@gmail.com>
@frawhst frawhst merged commit 78cd1bf into goonstation:master Sep 13, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@TheTyrant25 TheTyrant25 deleted the bloodflick branch September 14, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Feature A new feature or enhancements to existing features size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants