Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ashtrays and cigarette vendors to bar. #15628

Merged
merged 2 commits into from Sep 2, 2023

Conversation

TheTyrant25
Copy link
Contributor

[MAPPING] [QOL]

About the PR

It was noticed that the donut2 bar doesn't have an ashtray nor a nearby cigarette vendor. I decided to make sure every bar had an ashtray, and a cigarette machine reasonably close by.

Why's this needed?

Let smokers rp. Also map consistency is nice.

Changelog

(u)Tyrant
(+)All bars now have an ashtray and a nearby cigarette vendor.

@keywordlabeler keywordlabeler bot added A-Mapping A mapping change C-QoL A quality of life improvement that makes the game easier to play labels Sep 1, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2023
Copy link
Contributor

@flappybatpal flappybatpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I don't think the one on Oshan is required. Oshan has vending machine clusters in corridors and there is one very close right now.
  • Don't think the one on Clarion is required for similar reasons.
  • Nadir is OK if the existing machine is relocated up near medical.

Clarion:
image

Nadir 21 tiles away from the new machine:
image

Oshan:
image

@TheTyrant25
Copy link
Contributor Author

my eyes apparently glossed over those machines, whoops

@TobleroneSwordfish TobleroneSwordfish merged commit 17588a5 into goonstation:master Sep 2, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 2, 2023
@TheTyrant25 TheTyrant25 deleted the smoking branch September 3, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change C-QoL A quality of life improvement that makes the game easier to play size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants