Fixes failing to cast ability still triggering cooldown #15651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] [PLAYER ACTIONS]
About the PR
Fixes #15609, fixes #15514, fixes #13662 by making castcheck() failing return CAST_ATTEMPT_FAIL_NO_COOLDOWN instead of CAST_ATTEMPT_FAIL_DO_COOLDOWN
Why's this needed?
When abilities were being refactored some months ago the logic of cooldowns was changed such that the value that CAST_ATTEMPT_FAIL_DO_COOLDOWN was before (998) started triggering cooldowns when it previously did not.
Changelog