New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes ether's behaviour and recipe #15715
changes ether's behaviour and recipe #15715
Conversation
[LABEL][AI][Chemistry][Balance] ## About the PR <!-- Describe the Pull Request here. What does it change? What other things could this impact? --> This PR: Makes it so rattlesnakes no longer bite borgs and chase after people if their personal space is intruded. Changes the viper venom stagger effect for a 4 second stun. Removes the random +8 tox chance. Adds a small amount of bleed to complement the more dynamic take_bleeding_damage proc. ## Why's this needed? <!-- Describe why you think this should be added to the game. --> With the advent of the new critter spawn event, i've noticed that encounters with rattlesnakes tend to be a lot more aggressive on the part of the snake than i'd like. This should make them more forgivable to be around. As for the venom changes, the 10% chance of a +8 tox makes it wildly inconsistent, and stagger is rarely used in chemicals due to being mostly a combat effect, so i've changed those. As for the bleeding, a bump up on the bleeding speed should compensate for them no longer continuously biting you + the removal of the random extra damage. ## Changelog <!-- If necessary, put your changelog entry below. Otherwise, /please/ delete this entire section. --> ```changelog (u)Hans (+)Rattlesnakes will no longer chase people down unless directly attacked, they will still bite you if you get close. ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design ideas/concepts look good to me, though I'll defer to another more experienced dev's review for the code. I like the changes though!
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
!merge_upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reaction appears to duplicate ethanol?
It can also spontaneously detonate due to offgassing heating the mixture for some reason.
Aside from that I doubt it will see much use due to having a relatively annoying recipe and mediocre effects, but that was already the case so I don't see harm in trying to make it more interesting.
[LABEL][chemistry][feature][balance]
About the PR
This PR changes renames the ether chemical to Diethyl Ether, and restructures some of it's behaviour and the way in which it is made.
Behavior changes:
Diethyl Ether is extremely flammable, and besides combusting into a small fireflash at relatively low temperatures, also does it when in contact with any open flame.
Diethyl Ether now produces vapor when above 10c, making it continuously offgass at room temperature, which can be dangerous considering the vapor easily catches fire.
Diethyl Ether works slightly better as an anesthetic, having a higher overdose threshold(there is a big increase in difference between therapeutic and toxic doses), reducing the recent trauma effect, and having a 0.2 depletion unless currently KO-ing or above 10 units.
Diethyl Ether's KO moved to 40 cycles, but this can be reduced to 20 if more than 10 units present.
Recipe changes:
Base reagents(ethanol, hidrocloric acid and oxygen) remain the same, though the reaction only starts when above 30c.
Reaction now takes time, yielding Diethyl Ether at a base speed of 0.5 units per cycle, but that can increase with temperature. The reaction offgasses Diethyl Ether as well, but keeping the container closed causes it to cool the reaction, and requiring one to pay attention on heating to upkeep the reaction speed.
The reaction only happens while the amount of ether is inferior to the amount of ethanol present.
Why's this needed?
This gives the currently overlooked reagent Ether some more interesting effects, both in it's use in moderation as a easier to acquire anesthetic, and in it's possible use as a KO chemical. While it still is very much worse than capulettium in most regards, it now bridges the gap between it and morphine.
As per the reaction, Diethyl Ether's temperature based creation makes a compromise between how safe one wants to be and how expedient(and possibly effective) it's creation will be. It is easier to make than most other generic precursors, and if one keeps an eye on the reaction, it tends to go smoothly as well.