Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change amanitin to on_remove instead of moblifecomplete #15732

Merged
merged 2 commits into from Sep 11, 2023

Conversation

MRLinew
Copy link
Contributor

@MRLinew MRLinew commented Sep 7, 2023

About the PR

This PR changes amanitin to use on_remove instead of onmoblifecomplete. Right now, if anything flushes amanitin out, it does zero damage. using on_remove still has amanitin do its damage after its been flushed out. One thing to keep in mind is that this includes adminhealing, which purges the amanitin causing it to do damage after the players been healed.

Why's this needed?

Amanitin is kind of useless because when discovered it can be entirely negated.

Changelog

(u)Froggit Dogget
(+)Amanitin now does its damage when flushed out of the system.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 7, 2023
@Retrino
Copy link
Contributor

Retrino commented Sep 11, 2023

kind of seems like too big of a buff, considering amanitin has no indication of being in the bloodstream aside from randomly deciding to scan to check reagents? for something that can be grown and mass produced by botany it Should be purgable as a counter

@Tarmunora Tarmunora merged commit b1e2d9a into goonstation:master Sep 11, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants