Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handheld t-rays have cable/pipe/blueprint toggles and unique ability icons #15740

Merged
merged 10 commits into from Sep 15, 2023

Conversation

pgmzeta
Copy link
Contributor

@pgmzeta pgmzeta commented Sep 7, 2023

[QOL][Game Objects][Feature][Station Systems]

About the PR

  • By default, Handheld and PDA T-rays show the same information as before this PR.
  • Using a T-ray a in hand shows a context menu with four toggles:
  • Clicking the T-Ray ability button only toggles it on/off
  • T-rays have unique ability icons (no longer Flashlight Two)
  • PDA T-rays only have on or off functionality (as current)

This may have a second-hand effect on arcfiend wirehopping balance as it makes it easier to see wire paths.

Why's this needed?

  • Easier to focus on disposals or cables when you only care about one of those
  • Having the blueprint and actual pipe network as separate toggles makes it easier to figure out what's missing/broken
  • Having it on the handheld only gives it a little more utility now that engineers get t-ray PDA modules by default

Visual Edification (Screenshots)

Using the t-ray in hand for the first time

in_game_tray

With both pipes disabled, it's easier to see wiring

Screenshot 2023-09-14 164309

With everything disabled, you get to see underfloor atmos pipes (along with bot radio waypoints)

Screenshot 2023-09-14 164414

New T-ray scanner ability icon on/off sprites (with PDA for comparison)

Screenshot 2023-09-14 163554

Screenshot 2023-09-14 163539

TODOs

  • Cyborg t-ray check
  • Looks good enough

Changelog

(u)glowbold
(*)Using a T-ray scanner in-hand allows you to toggle seeing underfloor power cables, underfloor disposal pipes, and the station pipe blueprints independently.

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play labels Sep 7, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2023
Copy link
Member

@frawhst frawhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the PDA app would have something similar, but it does give the physical scanner an advantage over the app which is cool imo (and I understand why putting this on the app is impractical).

@pgmzeta pgmzeta marked this pull request as draft September 13, 2023 17:19
@pgmzeta
Copy link
Contributor Author

pgmzeta commented Sep 13, 2023

Before this gets merged I really want to implement on/off icons for the scanner parts; expecting in the next two days

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Sep 14, 2023
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2023
@pgmzeta pgmzeta changed the title handheld t-rays have cable/pipe/blueprint toggles handheld t-rays have cable/pipe/blueprint toggles and unique ability icons Sep 14, 2023
@pgmzeta pgmzeta marked this pull request as ready for review September 14, 2023 23:54
@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 15, 2023
@ZeWaka ZeWaka removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 15, 2023
code/WorkInProgress/AbilityItem.dm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Sep 15, 2023
@ZeWaka ZeWaka merged commit ffad733 into goonstation:master Sep 15, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 15, 2023
@pgmzeta pgmzeta deleted the tray-type-toggles branch September 21, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Station-Systems Deals with station systems, e.g. networks, power, shields, belt hell C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play C-Sprites Automatically applied on any .dmi or icons folder change S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants