Repath ABCU savefiles, make construction pausable, other fixes #15774

kbsmilk · 2023-09-09T18:40:59Z

[GAME OBJECTS][FEATURE]

About the PR

ABCU user savefiles are fragmented into separate savefiles for each blueprint. Old blueprints have to be migrated manually, individually, by the player that owns them. A verb does this, accessible when holding a Blueprint Marker.
Build jobs can now paused or canceled by players. To support this change, build material costs are now processed per-tile.
The ABCU now isn't deleted after a build job completes.
Fixes to object rebuilding, e.g. electric cables and APCs have better behavior now.
Some UI polish: ABCU gets tgui controls, more and rewritten feedback messages, ABCU's name var shortened.

Why's this needed?

Currently blueprints are stored in a single savefile for ALL users. This file is partially corrupted, making the blueprint system permanently unusable for certain users. Individual save files makes corruption manageable by users.
Canceling build jobs is just useful, and good for Future Plans :)

Changelog

(u)Smilg
(*)ABCU blueprints updated+fixed internally. You can migrate old blueprints with a blueprint marker tool.

Also adds feedback noises when selecting/unselecting tiles

safety prompts better help messages audio feedback re-added range limit

maxSize moved back under pixelaction canceling rect select makes a noise

and uses dmm_suite preloader to rebuild objects

it appears to work! started work on blueprint dump verb slightly renamed blueprint admin verbs to group them up

bit of admin logging that maybe works blueprint tileinfo now stores icon (as string)

building is now pausable and cancelable.

however, it does not load the icon.

frawhst · 2023-09-12T06:15:09Z

Currently blueprints are stored in a single savefile for ALL users.

This explains some things lmao

frawhst

Mostly small deletions. I don't know much about savefiles, but it looks generally fine to me.

code/WorkInProgress/blueprints.dm

Co-authored-by: aloe <frawhstdev@gmail.com>

kbsmilk · 2023-09-12T18:04:53Z

by god, clicking through "commit suggestion" 15 times while github refreshes and collapses the list every time. that'll teach me to clean up my commented code lol. Ty

ZeWaka · 2023-09-12T22:52:04Z

by god, clicking through "commit suggestion" 15 times while github refreshes and collapses the list every time. that'll teach me to clean up my commented code lol. Ty

You can bulk commit review suggestions on the review page

kbsmilk · 2023-09-29T06:38:36Z

Yay old blueprint migration is added. THE PR MUST GROW.

frawhst · 2023-10-02T16:51:32Z

I don't think testmerging this would play nice with the savefiles so let's try it!!!

kbsmilk added 28 commits July 17, 2023 18:00

Increases ABCU Marker range

ef3a553

Also adds feedback noises when selecting/unselecting tiles

cleanup by Mister-Moriarty

9e36f90

Rectangle select

84b0663

safety prompts better help messages audio feedback re-added range limit

Changed some usage info lines

aa6a558

a word

201a5d9

removed unused messages

c8b2401

fixed rect select marking forbidden tiles

c34d83c

'selecting' now uses defines

df35663

maxSize moved back under pixelaction canceling rect select makes a noise

now saves icon state

bc3da90

and uses dmm_suite preloader to rebuild objects

repathed save files for marker's save, print, and delete.

691cea5

it appears to work! started work on blueprint dump verb slightly renamed blueprint admin verbs to group them up

blueprints save author ckey now

f6f7ac7

bit of admin logging that maybe works blueprint tileinfo now stores icon (as string)

area power controllers now built last

fc61fa7

power terminal unwhitelisted

28b9248

log to station not to admin

46b86e8

build process now uses machinery loop.

9af9011

building is now pausable and cancelable.

resource consumption exists now + minor cleanup

7387317

simplified my insane build cost math

a3ac42e

more math fixes, material costs can be decimal now

3d1787b

upgraded user input to tgui, better handling

fce93e7

finished auditInventory(), now using it

2c291cd

code guide stuff: explicit src, true/false bools

bf977b9

more explicit src

75ada76

and more

3ef54fa

now saves turf icon if it's different from initial.

baa4293

however, it does not load the icon.

some polish + properly disabled icon loading

852af67

removed unused code, tiny bit of message polish

defb7cb

updated admin verbs

f25c0b7

abcu and marker use improper names, marker desc adjusted

a1fb308

github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 9, 2023

keywordlabeler bot added the A-Game-Objects The point of this PR is to deal with a specific game object label Sep 9, 2023

frawhst reviewed Sep 12, 2023

View reviewed changes

kbsmilk and others added 15 commits September 12, 2023 13:51

Update code/WorkInProgress/blueprints.dm

faa9223

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

315fefd

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

05efe37

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

43d0459

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

8ce4e01

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

9e6fdc0

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

d20df6c

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

9573c8a

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

725068d

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

4cd5548

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

a2f4166

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

334061f

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

f1da6ca

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

a2e0cb1

Co-authored-by: aloe <frawhstdev@gmail.com>

Update code/WorkInProgress/blueprints.dm

eed4726

Co-authored-by: aloe <frawhstdev@gmail.com>

kbsmilk and others added 3 commits September 12, 2023 19:52

removed extra return

0809326

lowercase and underscores

c4f5ae3

Merge branch 'master' into abcu-bigfix

cf93f26

frawhst approved these changes Sep 15, 2023

View reviewed changes

blueprint migration verb

540dd61

frawhst merged commit 83c929f into goonstation:master Oct 2, 2023
22 checks passed

github-actions bot pushed a commit that referenced this pull request Oct 2, 2023

Changelog for #15774 [skip ci]

9d8269f

This was referenced Oct 10, 2023

Blueprint Marker No blueprints for user found #15163

Closed

ABCU does not save cable orientation #15460

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Repath ABCU savefiles, make construction pausable, other fixes #15774

Repath ABCU savefiles, make construction pausable, other fixes #15774

kbsmilk commented Sep 9, 2023 •

edited

frawhst commented Sep 12, 2023

frawhst left a comment

kbsmilk commented Sep 12, 2023

ZeWaka commented Sep 12, 2023

kbsmilk commented Sep 29, 2023

frawhst commented Oct 2, 2023

Repath ABCU savefiles, make construction pausable, other fixes #15774

Repath ABCU savefiles, make construction pausable, other fixes #15774

Conversation

kbsmilk commented Sep 9, 2023 • edited

About the PR

Why's this needed?

Changelog

frawhst commented Sep 12, 2023

frawhst left a comment

Choose a reason for hiding this comment

kbsmilk commented Sep 12, 2023

ZeWaka commented Sep 12, 2023

kbsmilk commented Sep 29, 2023

frawhst commented Oct 2, 2023

kbsmilk commented Sep 9, 2023 •

edited