Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgui Elevators #15783

Merged
merged 8 commits into from Sep 12, 2023
Merged

tgui Elevators #15783

merged 8 commits into from Sep 12, 2023

Conversation

Garash2k
Copy link
Contributor

@Garash2k Garash2k commented Sep 10, 2023

About the PR

New UI for Oshan and Nadir's sea elevators, 2 azone elevators, and an admin only toilet paper roll elevator(?!)
image
image

Fixes the bug where 2 people on different floors could make the elevator move at the same time.
Fixes a bug where one azone elevator would actually make the other azone elevator play a ringing sound. Bug fixed by using the right type in a for in loop.

Why's this needed?

Looks better and more consistent with the AI turret panel which I sorta based it on
Old UI:
261918623-a774e870-0068-4991-8242-bf33e15b6e6a

Changelog

(u)Garash
(+)New UI for the elevators, descend to the trench in style!

[UI][Rework]

@boring-cyborg boring-cyborg bot added the A-UI Modifies UI in some way. Automatically applied on a change to tgui/ label Sep 10, 2023
@keywordlabeler keywordlabeler bot added the C-Rework Reworks a feature label Sep 10, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2023
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate to do this, but these really should be repathed to /obj/machinery/computer/elevator or similar. I know they're copy-pasted now, but that's not a reason to keep doing it.

Aside from that, this looks sweet!

@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Sep 11, 2023
@Garash2k
Copy link
Contributor Author

Repath is go!
Done, here are the repaths:
/obj/machinery/computer/icebase_elevator ->
/obj/machinery/computer/elevator/icebase
/obj/machinery/computer/biodome_elevator ->
/obj/machinery/computer/elevator/biodome
/obj/machinery/computer/sea_elevator ->
/obj/machinery/computer/elevator/sea
/obj/submachine/centcom_elevator ->
/obj/machinery/computer/elevator/centcomm

I'm not gonna be able to repath the other side of the centcomm elevator nor be able to test it very well (it goes to the void then stops working without secrets)

@ZeWaka
Copy link
Member

ZeWaka commented Sep 11, 2023

I'm not gonna be able to repath the other side of the centcomm elevator nor be able to test it very well (it goes to the void then stops working without secrets)

Could do an UpdatePaths but not really necessary for only one thing

@ZeWaka ZeWaka added the A-Secret Deals with secret content ⚿ label Sep 11, 2023
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2023
@ZeWaka ZeWaka merged commit 1ca0cea into goonstation:master Sep 12, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change A-Secret Deals with secret content ⚿ A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Rework Reworks a feature size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants