Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add orbital shakers to maps #15787

Merged
merged 1 commit into from Sep 13, 2023
Merged

Add orbital shakers to maps #15787

merged 1 commit into from Sep 13, 2023

Conversation

TheTyrant25
Copy link
Contributor

[MAPPING] [FEATURE] [CHEM]

About the PR

Adds one large chemistry orbital shaker to each rotation map, on top of a lab desk. Orbital shakers were merged 35 minutes ago in #15713

Why's this needed?

They are cool and are meant to be used

Changelog

(u)DisturbHerb, Tyrant
(*)Added the new orbital shakers to Chemical Labs, which shake glassware around and apply physical force to them.

@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Sep 10, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2023
@keywordlabeler keywordlabeler bot added A-Chemistry Deals with the chemistry system in some way C-Feature A new feature or enhancements to existing features labels Sep 10, 2023
DisturbHerb
DisturbHerb reviewed Sep 10, 2023
View reviewed changes
Copy link
Contributor

@DisturbHerb DisturbHerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no opinion on the placement of these, that they're in labs at all is fine by me

med pharmacists seething

@TheTyrant25
Copy link
Contributor Author

med pharmacists can deal with it
let them pr it themselves

@frawhst frawhst merged commit 618c061 into goonstation:master Sep 13, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@robuddybot
Changelog for #15787 [skip ci]
471927a
@TheTyrant25 TheTyrant25 deleted the orbital-shaker branch September 14, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DisturbHerb DisturbHerb DisturbHerb left review comments

@frawhst frawhst frawhst approved these changes

@Sord213 Sord213 Awaiting requested review from Sord213 Sord213 is a code owner

@flrsh flrsh Awaiting requested review from flrsh flrsh is a code owner

Assignees
No one assigned
Labels
A-Chemistry Deals with the chemistry system in some way A-Mapping A mapping change C-Feature A new feature or enhancements to existing features size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheTyrant25 @DisturbHerb @frawhst