Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemistry Cryostylane + Pyrosium Area Heat Effect + Slight Recipe Tweaks #15812

Merged
merged 2 commits into from Sep 28, 2023

Conversation

Flaborized
Copy link
Contributor

@Flaborized Flaborized commented Sep 12, 2023

[CHEMISTRY]

About the PR

This PR changes a few chemistry things with cryoxadone, cryostylane and pyrosium, nothing super major:

  • Mixing cryostylane and iodine now creates a cold area effect around it, cooling people and beakers and stuff. Non-instant, speed 1u
  • Pyrosium can be mixed with magnesium (instead of oxygen) to create a similar heat effect, with little flame animations (more dangerous with flammables nearby for sure)
  • Both of these reactions and pyrosium + oxygen and cryostylane + oxygen now don't consume the oxygen/magnesium/iodine when reacting, but keep count of how many cycles have passed and removes the oxy/mag right at the end in equal amounts. This means that if you mix 50u cryo and 50u oxy, the end of the reaction will deplete everything, but you can also just use 1u or 10u oxy if you prefer. Meant to be QoL and let you keep these reactions running longer if you want, vaguely like oil.
cryo_pyro_2.mp4

Why's this needed?

Something I wanted to add for a bit, I think I also saw someone in discord suggest something similar, I think the utility of being able to heat/cool multiple beakers with one reaction based on positioning is really cool, and I like adding more dramatic visuals to chemistry. I also think the "only technically requiring 1u of oxy" buffs to the cryo and pyro reactions should make them much more fun to use and cut down on some clicking.

Feedback on the changelog entries very welcome, not my necessarily strong suit :sheltersweat:

Changelog

(u)Flaborized
(*)Some small chemistry changes to pyrosium and cryostylane, including an area of effect heat/cool effect. More detailed description in minor logs.
(+)Pyrosium can now be mixed with magnesium to create a 3x3 area of effect heating effect, and cryostylane can be mixed with iodine for a cold version of the same thing.
(+)Pyrosium, cryostylane reactions now longer use up the oxygen/magnesium/iodine until the end of the reaction. This means it'll still deplete the oxygen, but you only technically need 1u to carry out the full reaction.

@keywordlabeler keywordlabeler bot added the A-Chemistry Deals with the chemistry system in some way label Sep 12, 2023
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Sep 12, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2023
@ZeWaka ZeWaka added the E-Add-To-Wiki A PR that will require changes to the wiki label Sep 12, 2023
plane = PLANE_OVERLAY_EFFECTS

New()
icon_state = pick("cryo-1", "cryo-2", "cryo-3", "cryo-4") //slightly different timings on these to give a less static look
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider just having the same sprite (less work) but offsetting horizontally for some of these, so it's less 'tiled'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the four sprites are actually just the one sprites flipped and with timing differences, I want it to look a little tiled so it's very clear which tiles are hit by the effect, since it's tile based and should reflect that visually

@wolfolotl
Copy link
Contributor

very neat, though I worry that the visual effects for the heat aura make it look equivalent to an area of open flame in the sense that it communicates a level of potential destruction that isn't there. it's a little more Actual Fire than a tile of an inferno, currently

Copy link
Member

@Tarmunora Tarmunora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using croxadone as a cooling agent is really weird, considering when acting as a medicine it heats the patient up (and requires cooling the patient to actually do anything etc.). I don't think this is a good direction to take it, personally

@Flaborized
Copy link
Contributor Author

Using croxadone as a cooling agent is really weird, considering when acting as a medicine it heats the patient up (and requires cooling the patient to actually do anything etc.). I don't think this is a good direction to take it, personally

forgot about that honestly :sheltersweat: will change it to be a variant of crostylane then (like how the other one is pyrosium + magnesium instead of oxygen

very neat, though I worry that the visual effects for the heat aura make it look equivalent to an area of open flame in the sense that it communicates a level of potential destruction that isn't there. it's a little more Actual Fire than a tile of an inferno, currently

sure, I see what you mean, though I still want it to look like a heat-related hazard since it can light up fuel tanks and stuff. will try and draw something up that communicates this and then probs use this flame effect for something more fire-y later since I do think it looks pretty cool

@Flaborized Flaborized changed the title Chemistry Cryoxadone + Pyrosium Area Heat Effect + Slight Recipe Tweaks Chemistry Cryostylane + Pyrosium Area Heat Effect + Slight Recipe Tweaks Sep 13, 2023
@Flaborized
Copy link
Contributor Author

Flaborized commented Sep 13, 2023

Switched the animation for the heat effect to this more abstract warm swirlies, hopefully looks less like it should burn you to death. Kept the fire in the file though since it looks nice and would fit well on something that actually does burn you to death later. It still looks a bit like a hazard but it's difficult to draw something that looks hot but not dangerous and I think this is Better. Also updated the PR video to show the new effect

Changed the cryoxadone reactions back to regular, instead moved the cold aoe to cryostylane + iodine. No particular reason I used iodine, magnesium and it were picked mostly because they're seldom used in recipes so you won't get a lot of conflicts or accidental triggers.

@TobleroneSwordfish TobleroneSwordfish merged commit ddf6a8a into goonstation:master Sep 28, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Chemistry Deals with the chemistry system in some way C-Sprites Automatically applied on any .dmi or icons folder change E-Add-To-Wiki A PR that will require changes to the wiki size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants