Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assless chaps, uniform -> Chaps, outer suit #15820

Merged
merged 3 commits into from Sep 19, 2023
Merged

Assless chaps, uniform -> Chaps, outer suit #15820

merged 3 commits into from Sep 19, 2023

Conversation

kbsmilk
Copy link
Contributor

@kbsmilk kbsmilk commented Sep 13, 2023 •
edited

[GAME OBJECTS] [FEATURE]

About the PR

  • Assless chaps are now just called chaps.
  • Moved to outer suit slot due to its sprite. Repathed from /obj/item/clothing/under/gimmick/chaps to /obj/item/clothing/suit/chaps, within code\obj\item\clothing\gimmick.dm.
  • Sprites are now moved, to the 3 gimmick overcoat .dmis.

Why's this needed?

This "leather fetish item" is not good anymore

Changelog 

(u)Smilg
(+)Assless chaps replaced with regular chaps.

@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Sep 13, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2023
@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features labels Sep 13, 2023
@DimWhat
Copy link
Contributor

DimWhat commented Sep 13, 2023

All suit slot items should be with the rest of their people, i suggest finding a spot for it in a proper file for organization's sake.

@flappybatpal
Copy link
Contributor

Between the inclusion of the strapped top and the name (there is no such thing as assless chaps, it's just chaps) it does seem like a poorly aged item.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Sep 13, 2023
@kbsmilk
Copy link
Contributor Author

kbsmilk commented Sep 13, 2023

Sprites are now moved, also the obj def is moved to the gimmick clothes super-file.

@TobleroneSwordfish TobleroneSwordfish merged commit 26907d0 into goonstation:master Sep 19, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
@robuddybot
Changelog for #15820 [skip ci]
e5c671f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tarmunora Tarmunora Tarmunora approved these changes

Assignees
No one assigned
Labels
A-Game-Objects The point of this PR is to deal with a specific game object A-Mapping A mapping change C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kbsmilk @DimWhat @flappybatpal @Tarmunora @TobleroneSwordfish