Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds empty gas tanks to the general manufacturer #15841

Merged
merged 7 commits into from Sep 20, 2023

Conversation

TealSeer
Copy link
Contributor

[FEATURE] [GAME OBJECTS] [SPRITES]

About the PR

Re-sprites the base gas tank, adds missing worn and inhand sprites, and adds a recipe for it costing 0.1 sturdy metal to the general manufacturer.

Old (left) vs new (right) sprite comparison
image

Worn sprite
image

Inhand sprite
image

Why's this needed?

Not being able to get an empty gas tank to use without either having access to a place with a tank dispenser or scavenging one from o2 lockers sucks, and you can already manufacture empty canisters at the general manufacturer.

Changelog

(u) TealSeer
(+) Empty gas tanks can now be made at the general manufacturer for 0.1 sturdy metal.

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features labels Sep 14, 2023
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Sep 14, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2023
@DimWhat
Copy link
Contributor

DimWhat commented Sep 15, 2023

I'd like to request a monkey version for parity.

@TealSeer
Copy link
Contributor Author

@DimWhat where do those sprites live? I'll do one

@DimWhat
Copy link
Contributor

DimWhat commented Sep 15, 2023

@TealSeer Monkey sprites are found in icons/mob/monkey/back.dmi

@M-Earthfire
Copy link
Contributor

M-Earthfire commented Sep 15, 2023

Maybe a sprite for this one when its attached to a TTV?

@CheffieGithub
Copy link
Contributor

I would make a subtype rather than use the tank parent

@TealSeer
Copy link
Contributor Author

Maybe a sprite for this one when its attached to a TTV?

oh I forgot to include pictures in the OP but it does have a TTV sprite it looks like this:
image

@TealSeer
Copy link
Contributor Author

I would make a subtype rather than use the tank parent

actually yeah probably a better idea

@MeggalBozale
Copy link
Contributor

yum easier ttv production (not really an issue though)

@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Sep 19, 2023
@Sord213 Sord213 merged commit b712792 into goonstation:master Sep 20, 2023
23 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 20, 2023
@TealSeer TealSeer deleted the tank-shit branch November 24, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants