Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Glaucus Fishing Rod, 6tc traitor item #15858

Merged
merged 15 commits into from Sep 22, 2023

Conversation

MylieDaniels
Copy link
Contributor

@MylieDaniels MylieDaniels commented Sep 16, 2023

[A-Game-Objects] [C-Feature] [C-Sprites] [E-Add-to-Wiki]

About the PR

This adds the Glaucus Fishing Rod, a 6 tc item for Rancher and Angler traitors.
image

Traps can be set up with the lure, which can be disguised (kinda like a chameleon bomb) by smacking the Glaucus with any item. Click to throw the lure out, click to reel in. Use in-hand to reel in one tile, for the classic dollar bill trick or to adjust your trap. If someone picks it up, they'll suffer a 4 second stun, 15 damage, and get embedded with the hook. If they are hit with the hook while it's being thrown out or reeled in, they'll also be embedded, but will suffer 5 damage and no stun.

While hooked, you are quite slowed. The hook can be removed through surgery (this is more of a technicality, but if you have a morphine auto-injector and a knife, go wild), by getting 9 tiles away from the rod, or by the wielder using the rod in hand.

Reeling in while someone is hooked will start a looping 0.7 second action bar- on each completion, the hooked mob is pulled 1 tile closer, and if they are in melee range they take 7 damage. If they aren't in melee range, 3 damage is added to the "pending" damage- this is applied to the next successful melee reel in the same set of reels, and if a melee reel does 25 or more damage, it stuns for SQRT(damage) / 3 seconds. After a successful melee reel or if the line is broken/lure removed, damage is reset to 7 again.

Clicking while a mob is on the line will throw them about 3-4 tiles on a 6 second cooldown. Best used as an opener, so place lures next to glass tables, vending machines, or open airlocks!

fishing.mp4

TODO: Completed

  • Unique inhand sprites - now bulky red fishing rod
  • Non-beartrap sprite for default lure - now uses minnow
  • Fix casting from inside lockers - now only allows reeling, casting, and actionbar while on turf

Why's this needed?

I like fishing, I like traitor weapons, and I think you should too. Also, rancher has 1 traitor item and angler has 0.

Changelog

(u)MylieDaniels, AveryQuill
(*)Adds the Glaucus Fishing Rod, a 6 tc tacticool fishing rod for catching crew with disguised hooks. Available to Rancher and Angler traitors, as well as through surplus crates.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Sep 16, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 16, 2023
@MylieDaniels MylieDaniels changed the title Glaucus Adds Glaucus Fishing Rod, 7tc traitor item Sep 16, 2023
@pgmzeta pgmzeta added C-Feature A new feature or enhancements to existing features E-Add-To-Wiki A PR that will require changes to the wiki A-Game-Objects The point of this PR is to deal with a specific game object labels Sep 16, 2023
@Glamurio
Copy link
Contributor

What a sick item! I love it! One small caveat I have, and realize might be more problematic to implement, but for visual clarity, would it be possible to draw a line from the rod user to the target?

Maybe also some interaction about people running into the line, like, tripping or something. Would make it even more amusing. Just ideas, ultimately I wouldn't be upset if the item got in the way it is. Excited for it!

@444Portal
Copy link
Contributor

What a sick item! I love it! One small caveat I have, and realize might be more problematic to implement, but for visual clarity, would it be possible to draw a line from the rod user to the target?

Maybe also some interaction about people running into the line, like, tripping or something. Would make it even more amusing. Just ideas, ultimately I wouldn't be upset if the item got in the way it is. Excited for it!

Would probably counteract some of the utility of being able to scan in an item as bait, and hiding in like a bush or something. Just my personal opinion.

@MylieDaniels MylieDaniels marked this pull request as ready for review September 16, 2023 22:09
@Vispectral
Copy link

Very Interesting Item I'd say, shame it's locked behind Rancher. Unique, flavorful and fits a niche theme.
The design seems alright. I'm sure Gannets would be a massive fan of this item.

My downside would be cost. I do not think personally this is on par with 7 TC items. Compared to Cyalume Saber which does 60 and reflects, fits in your pockets.
Wrestlebelt which is probably the ultimate 1v1 item and
Katana which can totally be used to wipe out stations ..

This by comparison is rather tame. I'd advocate for 6 or 5 TC perhaps allowing it to used in conjunction with other items to promote interesting gameplay. Unless if as some people suggested here, you could "scan" items to use as bait and even then, I still feel 7 is expensive.

Excellent work Mylie.

@MylieDaniels
Copy link
Contributor Author

Ah, I don't know if I was clear in my explanation, you can in fact scan items to act as bait- this disguises the bait as the item.
However I do see that it's definitely not as strong as a c-saber or katana and doesn't have anywhere near the power of a wrestlebelt or red chainsaw. I will lower the price to 6 tc, mostly because I worry about the combo potential with 7 tc items if it were 5- though if a developer has opinions on it being higher or lower, I'd love to hear from them.

@MylieDaniels MylieDaniels changed the title Adds Glaucus Fishing Rod, 7tc traitor item Adds Glaucus Fishing Rod, 6tc traitor item Sep 16, 2023
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horrific, I love it. It'd be neat if it could act as a high tier fishing rod too.

code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
code/modules/fishing/fishing_gear.dm Outdated Show resolved Hide resolved
@MylieDaniels
Copy link
Contributor Author

Thank you for the reviews, I'll get to work fixing the issues in the morning.

@MylieDaniels
Copy link
Contributor Author

MylieDaniels commented Sep 19, 2023

It'd be neat if it could act as a high tier fishing rod too.

I'm unsure how to best implement this, as clicking on a fishing spot while fighting would be frustrating I think.

@444Portal
Copy link
Contributor

It'd be neat if it could act as a high tier fishing rod too.

I'm unsure how to best implement this, as clicking on a fishing spot while fighting would be frustrating I think.

How would using it on help intent sound?

@MylieDaniels
Copy link
Contributor Author

It'd be neat if it could act as a high tier fishing rod too.

I'm unsure how to best implement this, as clicking on a fishing spot while fighting would be frustrating I think.

How would using it on help intent sound?

I don't know about others, but I'm the type to use weaponry on help intent at times...

@TobleroneSwordfish TobleroneSwordfish merged commit d0ab039 into goonstation:master Sep 22, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@MylieDaniels MylieDaniels deleted the glaucus branch October 1, 2023 18:16
@Retrino Retrino removed the E-Add-To-Wiki A PR that will require changes to the wiki label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants