Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprites EOD Gear #15900

Merged

Conversation

MitchTheUser
Copy link
Contributor

@MitchTheUser MitchTheUser commented Sep 19, 2023

[Clothing]

About the PR

Resprites both the Bomb Defusal Suit and the Blast Helmet found in the armory. The outfit has been changed to match it's worn sprites, which now causes the items sprites to be of higher quality than the current sprites. The inhand sprites for both the suit and the helmet have also been completely remade to match the new sprites.

EODDisplay

Why's this needed?

The current sprites are old, and they are drastically different than their worn sprites. Consistency between the item sprites and worn sprites are good, and the new sprites can now benefit from having more detail and will fit in visually with other Security gear.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Sep 19, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2023
@keywordlabeler keywordlabeler bot added the A-Clothing Deals with clothing of whatever sort label Sep 19, 2023
@Valtsu0
Copy link
Contributor

Valtsu0 commented Sep 20, 2023

IIRC the blast helmet shares a sprite with another helmet (i think donk co helmet, maybe elite helmet?). I can't test at the moment if it is affected, but you should make sure it is how it is supposed to be

@MitchTheUser
Copy link
Contributor Author

IIRC the blast helmet shares a sprite with another helmet (i think donk co helmet, maybe elite helmet?). I can't test at the moment if it is affected, but you should make sure it is how it is supposed to be

You're right, the Donk space helmet shares the same sprite as the Blast Helmet, so it was affected by this PR. However, when testing it, I found that the Donk helmet and Blast helmet share the same worn sprite, which is what I based the new helmet sprite off of, so it actually kind of works in its favor, as the Donk space helmet now matches its worn sprite, though unintentionally.

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 22, 2023
@frawhst
Copy link
Member

frawhst commented Sep 22, 2023

!merge_upstream

@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 22, 2023
@TobleroneSwordfish TobleroneSwordfish merged commit 00c327f into goonstation:master Sep 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Clothing Deals with clothing of whatever sort C-Sprites Automatically applied on any .dmi or icons folder change size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants