Choking prevents the inhalation of smoke or smoking reactions #15909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keywordlabeler
bot
added
A-Chemistry
github-actions
bot
added
the
size/XS
M-Earthfire
changed the title
keywordlabeler
bot
added
the
E-Input-Wanted
|
Created discussion thread: https://forum.ss13.co/showthread.php?tid=21806 |
Glamurio
approved these changes
Sep 20, 2023
unfunnyperson
approved these changes
Oct 1, 2023
github-actions
bot
added
the
S-Ready-For-Final-Review
|
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
github-actions
bot
added
the
S-Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CHEMISTRY][INPUT WANTED][BALANCE]
About the PR
This PR prevents inhaling smoked chemicals while losebreath is higher than 0. This means smoke won't be inhaled when you cannot breath due to choking from chems/strangulation.
It applies to reactions that makes you inhale without a gas mask, like meth, as well.
Keep in mind this does not apply to asphixiation due to spaced enviroment.
Why's this needed?
It kinda makes no sense that you are to breath in smoke while actively choking and struggling to breath. This mostly affects chemicals which makes you struggling to breath e.g. cyanide. Also, this makes dying people in smoke not continue to suck of chemicals out of the smoke.
This will make perfluorodecalin able to make you walk through non-skinpen smoke without problems, but since gas masks are fairly aquireable, this shouldn't be much of a problem. It enables perfluorodecalin to be an emergency tool for sudden smoking, though.
This PR enables additional mechanics and design space, like improving what stuff like what #15908 tries to achieve.
Changelog