New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor light fixture placing #15911
Conversation
I still have some minor merge conflicts to resolve and want to test it a bit before then, after that it should be good to merge hopefully. Also, the RCD will still smack things with this, but I'd rather change that in a subsequent PR since this is already sizable and I might have to shuffle some RCD code around. |
finally, nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ingame and seems good.
About the PR
Refactors light fixture placement code a bit to move the stuff out of the walls and floors and into the light fixture object.
Why's this needed?
Changelog