Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fried foods permanently being placed inside mob #15914

Closed
wants to merge 3 commits into from

Conversation

Glamurio
Copy link
Contributor

[Bug] [Catering] [Balance]

About the PR

Fried foods no longer do set_loc() on the mob, but instead just get digested normally like any other item would.

Why's this needed?

Currently, when any item is fried and eaten, it will place itself inside a mob via set_loc. There are no known methods (to me) to remove this item again, meaning that you end up with strange results like people eating telecrystals permanently teleporting with no cure, or endlessly radiating erebite that cannot be removed even with ipecac.

@keywordlabeler keywordlabeler bot added A-Catering Deals with food, the chef, the bar or otherwise edible/drinkable stuff C-Balance Balance changes, buffs and nerfs C-Bug A bug that impacts usage of a feature labels Sep 21, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2023
@TobleroneSwordfish TobleroneSwordfish mentioned this pull request Sep 21, 2023
1 task
@Tarmunora
Copy link
Member

what about changing it from using stomach_contents to stomach_process? `The former appears mostly deprecated and seems intended to only contain uh... mobs.

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 22, 2023
@Glamurio
Copy link
Contributor Author

Glamurio commented Sep 22, 2023

stomach_process

Sort of irrelevant now that #15919 got merged which overhauls the entire system, so I'm just going to use C.organHolder.stomach.consume instead. In fact, it may just render this PR null and I'll do another one if I notice any issues.

@Glamurio Glamurio closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Catering Deals with food, the chef, the bar or otherwise edible/drinkable stuff C-Balance Balance changes, buffs and nerfs C-Bug A bug that impacts usage of a feature S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants