Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIV2 split parameters into queryParams and routeParams #15938

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

TobleroneSwordfish
Copy link
Contributor

About the PR

Splits the api route parameters into query and route params and adds handling for them in the route generation.

Why's this needed?

Route params do exist

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2023
code/modules/goonhub/api/routes/apiRoute.dm Outdated Show resolved Hide resolved
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
@ZeWaka ZeWaka added C-Feature A new feature or enhancements to existing features C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. A-Internal Deals with major internal, generally non-player facing code - e.g. types labels Sep 22, 2023
@TobleroneSwordfish TobleroneSwordfish merged commit 03579cd into goonstation:apiv2 Sep 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Internal Deals with major internal, generally non-player facing code - e.g. types C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. C-Feature A new feature or enhancements to existing features size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants