Scale banana peel size to banana size #15953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/XS
|
Please note I'm a hobby coder with minimal Dream Maker experience - if there's a better or more efficient way to do this, please let me know! Thanks for the review :3 |
frawhst
approved these changes
Sep 22, 2023
ZeWaka
added
C-Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[A-Hydroponics][C-Feature]
About the PR
Use a banana's transform (size scaling) matrix to determine the size of the resulting peel after being opened. Minimum size of 80% to prevent micro peels in cases of very unloved rotting bananas. I'm not tied to the floor being 80%. This looked visually appealing to me, and I've been told it's hard to get the size very low.
Current visuals below of a jumbo banana (top), normal banana (middle), and rotting banana (bottom)
Why's this needed?
Getting a normal peel after botany worked hard to make a big banana seems counterintuitive. Also big peels are funny.
Changelog