Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revolutionary sign damage scales with number of nearby revs #15962

Merged
merged 5 commits into from Sep 25, 2023

Conversation

unfunnyperson
Copy link
Contributor

@unfunnyperson unfunnyperson commented Sep 23, 2023

[BALANCE] [GAME OBJECTS]

About the PR

Revsign damage scales with nearby revs in a 5 tile radius, Each rev is 5 extra damage up to a max of 25 damage(The user will count toward this)
Lowers base damage of the sign to 3
Non-revs do not gain the damage buff if they attack using the sign

Why's this needed?

The revolutionary sign isn't a very good item in its current state. Its extremely loud, deals little damage, and the buff it gives isnt very good. Compared to the syndie dagger which has a very powerful stun ability and a cheaper cost, the revsign is a poor choice. This change is intended to make the revsign worth the 4 tc.

Changelog

(u)UnfunnyPerson
(+)Revolutionary sign damage scales depending on how many revs are nearby the user

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs labels Sep 23, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2023
code/datums/syndicate_buylist.dm Show resolved Hide resolved
code/obj/item/misc_weapons.dm Show resolved Hide resolved
Copy link
Contributor

@MeggalBozale MeggalBozale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@github-actions github-actions bot added the S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) label Sep 24, 2023
@TobleroneSwordfish TobleroneSwordfish merged commit 0240759 into goonstation:master Sep 25, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 25, 2023
@unfunnyperson unfunnyperson deleted the revsign-buff branch September 25, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs S-Ready-For-Final-Review This PR has been looked over by members of the community. (automatic after 2 approvals) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants